Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Usage of CSI Provisioner in csi-smb-controller #145

Closed
kferrone opened this issue Nov 11, 2020 · 2 comments · Fixed by #147
Closed

Update Usage of CSI Provisioner in csi-smb-controller #145

kferrone opened this issue Nov 11, 2020 · 2 comments · Fixed by #147
Assignees

Comments

@kferrone
Copy link

kferrone commented Nov 11, 2020

What happened:
I tried to run the chart on nodes with arm64 and the CSI Provisioner image must be v2.0.4 to support multiarch. The current version in the chart is defaulted to v1.4.0 which does not have a multiarch build and therefore will not run on arm64.

If I use the default repository of: mcr.microsoft.com/oss/kubernetes-csi/csi-provisioner:v2.0.4; then I can't even pull the image.

If I use k8s.gcr.io/sig-storage/csi-provisioner:v2.0.4; then the image pulls and actually runs on arm64.
However I do get this error:

unknown flag: --enable-leader-election
Usage of /csi-provisioner:
unknown flag: --enable-leader-election

Basically it shows a big list of flags that can be used and --enable-leader-election is actually not an option, nor is it here: https://github.com/kubernetes-csi/external-provisioner

I tracked down the csi-smb-controller file, it seems it needs an update to the args.

What you expected to happen:
Correctly run the latest and greatest csiProvisioner with up to date flags. This way Arm64 is one step closer to using smb-csi.

How to reproduce it:
Here is my values.yaml to run on some arm nodes:

image:
  smb:
    tag: latest
  csiProvisioner:
    repository: k8s.gcr.io/sig-storage/csi-provisioner
    # tag: v1.6.1
    tag: v2.0.4
  livenessProbe:
    repository: k8s.gcr.io/sig-storage/livenessprobe
    tag: v2.1.0
  nodeDriverRegistrar:
    repository: k8s.gcr.io/sig-storage/csi-node-driver-registrar
    tag: v2.0.1
@andyzhangx
Copy link
Member

/assign @mayankshah1607
@mayankshah1607 can you fix this issue by using k8s.gcr.io images and also fixed the enable-leader-election issue? thanks

@andyzhangx
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants