CI: add golint and misspell to static checks

[mayankshah1607]

chore: remove redundant hack/* scripts and move linting to static checks

Signed-off-by: Mayank Shah [email protected]

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

• Remove redundant scripts from hack/* and introduce them as a part of golangci-linter

Which issue(s) this PR fixes:

Fixes #

Requirements:

• uses conventional commit messages
• includes documentation
• adds unit tests
• tested upgrade from previous version

Special notes for your reviewer:

Release note:

none

[k8s-ci-robot]

Hi @mayankshah1607. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[coveralls]

Pull Request Test Coverage Report for Build 284001747

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 87.658%

---

Totals
Change from base Build 279784693:	0.0%
Covered Lines:	625
Relevant Lines:	713

---

💛 - Coveralls

[andyzhangx]

is govet check covered?

[mayankshah1607]

Yes, it is enabled by default

[andyzhangx]

by static.yaml ? I don't see govet config in that file.

[mayankshah1607]

govet is enabled by default in golangci-linter - https://golangci-lint.run/usage/linters/
It does not have to be explicitly mentioned, unless it has to be disabled :)

[andyzhangx]

let's keep the original script, it's still useful in local dev, dev could run hack/verify-all.sh before submitting PR,

[mayankshah1607]

Okay, shall we remove make verify from the workflow then? It would just run the same checks twice

[andyzhangx]

let's keep it for a period of time, finally should remove the check in pull-csi-driver-smb-verify, pull-csi-driver-smb-unit and travis test. Need stabilization time.

[mayankshah1607]

Thanks @andyzhangx
I have added the required linters to golangci-lint action.

let's keep it for a period of time, finally should remove the check in pull-csi-driver-smb-verify, pull-csi-driver-smb-unit and travis test. Need stabilization time.

Shall I open an issue for this so that it is kept track of?

[andyzhangx]

/lgtm
/approve
/ok-to-test

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, mayankshah1607

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [andyzhangx]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[andyzhangx]

/test pull-csi-driver-smb-e2e-windows