cleanup: migrate make verify to static checks and remove redundant

scripts

Signed-off-by: Mayank Shah <[email protected]>

.github/workflows/static.yaml

@@ -1,16 +1,35 @@
 name: Static Checks
 on:
-    pull_request: {}
-    push: {}
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
 jobs:
-    go_lint:
-        name: Go Lint
-        runs-on: ubuntu-18.04
-        steps:
-            - name: Checkout code
-              uses: actions/checkout@master
-            - name: Run linter
-              uses: golangci/golangci-lint-action@v1
-              with:
-                  version: v1.29
-                  args: -E=gofmt --timeout=30m0s
+  static_checks:
+    name: Go Lint
+    runs-on: ubuntu-18.04
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@master
+      - name: Run linter
+        uses: golangci/golangci-lint-action@v1
+        with:
+          version: v1.29
+          args: '-E=gofmt,golint,misspell --timeout=30m0s'
+  yaml_lint:
+    name: YAML lint
+    runs-on: ubuntu-18.04
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@master
+      - name: yaml-lint
+        uses: ibiqlik/action-yamllint@v1
+  misc_checks:
+    name: Miscellaneous checks
+    runs-on: ubuntu-18.04
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@master
+      - name: yaml-lint
+        run: |
+          make verify

.github/workflows/ubuntu.yml

@@ -30,7 +30,6 @@ jobs:
     - name: Build Test
       run: |
         export PATH=$PATH:$HOME/.local/bin
-        make verify
         go test -covermode=count -coverprofile=profile.cov ./pkg/...
         export DOCKER_CLI_EXPERIMENTAL=enabled && make container
 

hack/verify-all.sh

@@ -18,11 +18,6 @@ set -euo pipefail
 
 readonly PKG_ROOT="$(git rev-parse --show-toplevel)"
 
-${PKG_ROOT}/hack/verify-gofmt.sh
-${PKG_ROOT}/hack/verify-govet.sh
-${PKG_ROOT}/hack/verify-golint.sh
-${PKG_ROOT}/hack/verify-yamllint.sh
 ${PKG_ROOT}/hack/verify-boilerplate.sh
-${PKG_ROOT}/hack/verify-spelling.sh
 ${PKG_ROOT}/hack/verify-helm-chart.sh
 ${PKG_ROOT}/hack/verify-gomod.sh