Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove preStop hook #176

Merged
merged 1 commit into from
Apr 16, 2020
Merged

Conversation

jsafrane
Copy link
Contributor

node-driver-registar image is distrolles and does not have /bin/sh. The hook always fails.

/kind bug

Which issue(s) this PR fixes:

Fixes #175

See also kubernetes-csi/node-driver-registrar#21

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Removed useless preStop hooks from the driver pod.

node-driver-registar image is distrolles and does not have /bin/sh. The
hook always fails.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 16, 2020
@k8s-ci-robot k8s-ci-robot requested review from msau42 and saad-ali April 16, 2020 13:19
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 16, 2020
@msau42
Copy link
Collaborator

msau42 commented Apr 16, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2020
@k8s-ci-robot k8s-ci-robot merged commit e244246 into kubernetes-csi:master Apr 16, 2020
mwennrich added a commit to metal-stack/csi-driver-lvm that referenced this pull request May 5, 2020
node-driver-registar image is distroless and does not have /bin/sh. The hook always fails.

see also
- kubernetes-csi/csi-driver-host-path#176
- kubernetes-csi/csi-driver-host-path#175
mwennrich added a commit to metal-stack/csi-driver-lvm that referenced this pull request May 5, 2020
node-driver-registar image is distroless and does not have /bin/sh. The hook always fails.

see also
- kubernetes-csi/csi-driver-host-path#176
- kubernetes-csi/csi-driver-host-path#175
TerryHowe pushed a commit to TerryHowe/csi-driver-host-path that referenced this pull request Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PreStop hook always fails
3 participants