-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove preStop hook #176
Merged
k8s-ci-robot
merged 1 commit into
kubernetes-csi:master
from
jsafrane:fix-pre-stop-hook
Apr 16, 2020
Merged
Remove preStop hook #176
k8s-ci-robot
merged 1 commit into
kubernetes-csi:master
from
jsafrane:fix-pre-stop-hook
Apr 16, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node-driver-registar image is distrolles and does not have /bin/sh. The hook always fails.
k8s-ci-robot
added
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
kind/bug
Categorizes issue or PR as related to a bug.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
labels
Apr 16, 2020
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
labels
Apr 16, 2020
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Apr 16, 2020
mwennrich
added a commit
to metal-stack/csi-driver-lvm
that referenced
this pull request
May 5, 2020
node-driver-registar image is distroless and does not have /bin/sh. The hook always fails. see also - kubernetes-csi/csi-driver-host-path#176 - kubernetes-csi/csi-driver-host-path#175
mwennrich
added a commit
to metal-stack/csi-driver-lvm
that referenced
this pull request
May 5, 2020
node-driver-registar image is distroless and does not have /bin/sh. The hook always fails. see also - kubernetes-csi/csi-driver-host-path#176 - kubernetes-csi/csi-driver-host-path#175
TerryHowe
pushed a commit
to TerryHowe/csi-driver-host-path
that referenced
this pull request
Oct 17, 2024
prow.sh: bump Go to 1.17.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/bug
Categorizes issue or PR as related to a bug.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
release-note
Denotes a PR that will be considered when it comes time to generate release notes.
size/S
Denotes a PR that changes 10-29 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node-driver-registar image is distrolles and does not have /bin/sh. The hook always fails.
/kind bug
Which issue(s) this PR fixes:
Fixes #175
See also kubernetes-csi/node-driver-registrar#21
Special notes for your reviewer:
Does this PR introduce a user-facing change?: