-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PreStop hook always fails #175
Comments
@jsafrane this is same as kubernetes-csi/node-driver-registrar#21 will be fixed by kubernetes-csi/node-driver-registrar#61 |
Nice! I'll remove the PreStop from manifests here, they don't work and there is no plan to add shell to node-driver-registrar. |
Merged
This was referenced Apr 17, 2020
mwennrich
added a commit
to metal-stack/csi-driver-lvm
that referenced
this issue
May 5, 2020
node-driver-registar image is distroless and does not have /bin/sh. The hook always fails. see also - kubernetes-csi/csi-driver-host-path#176 - kubernetes-csi/csi-driver-host-path#175
mwennrich
added a commit
to metal-stack/csi-driver-lvm
that referenced
this issue
May 5, 2020
node-driver-registar image is distroless and does not have /bin/sh. The hook always fails. see also - kubernetes-csi/csi-driver-host-path#176 - kubernetes-csi/csi-driver-host-path#175
TerryHowe
pushed a commit
to TerryHowe/csi-driver-host-path
that referenced
this issue
Oct 17, 2024
images: use k8s-staging-test-infra/gcb-docker-gcloud
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
csi-hostpath manifests here and in kubernetes/kubernetes contains PreStop hook to remove the driver socket before containers dies.
Since node-driver-registrar container is distroless, the hook always fails:
I0330 08:31:17.836238 1362 event.go:278] Event(v1.ObjectReference{Kind:"Pod", Namespace:"ephemeral-5231", Name:"csi-hostpathplugin-0", UID:"ad6006d7-6425-4661-829e-8106640183fb", APIVersion:"v1", ResourceVersion:"1676", FieldPath:"spec.containers{node-driver-registrar}"}): type: 'Warning' reason: 'FailedPreStopHook' Exec lifecycle hook ([/bin/sh -c rm -rf /registration/csi-hostpath /registration/csi-hostpath-reg.sock]) for Container "node-driver-registrar" in Pod "csi-hostpathplugin-0_ephemeral-5231(ad6006d7-6425-4661-829e-8106640183fb)" failed - error: command '/bin/sh -c rm -rf /registration/csi-hostpath /registration/csi-hostpath-reg.sock' exited with 126: , message: "OCI runtime exec failed: exec failed: container_linux.go:349: starting container process caused \"exec: \\\"/bin/sh\\\": stat /bin/sh: no such file or directory\": unknown\r\n"
Sadly, events are not available in prow job artifacts, it's visible only in kubelet logs.
The text was updated successfully, but these errors were encountered: