Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding option to send number of retries to override default value of 3. #780

Closed
wants to merge 4 commits into from

Conversation

chowmean
Copy link
Contributor

This PR addresses #652
Adding option in configuration and rest client object to send number of retries value to override the default value of 3 in urllib3.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 16, 2019
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 16, 2019
@chowmean
Copy link
Contributor Author

/assign @lavalamp

@lavalamp
Copy link
Member

/assign @roycaihw

@lavalamp lavalamp removed their assignment Mar 18, 2019
@roycaihw
Copy link
Member

these files are generated by swagger-codegen. The changes will be overwritten when we regenerate the client

you could send a PR to swagger-codegen to fix it upstream, and update the patch to carry it in the meantime

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chowmean
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: roycaihw

If they are not already assigned, you can assign the PR to them by writing /assign @roycaihw in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chowmean
Copy link
Contributor Author

Created the PR in upstream. swagger-api/swagger-codegen#9284

@chowmean
Copy link
Contributor Author

@roycaihw by update the patch to carry it in the meantime, did you mean this?
git diff >> scripts/rest_client_retries_patch.diff
Need help here.

@wing328
Copy link

wing328 commented Mar 20, 2019

@chowmean do you mind filing a PR for https://github.com/OpenAPITools/openapi-generator as well?

I believe eventually we want to replace Swagger Codegen with OpenAPI Generator in this project: kubernetes-client/gen#93

@chowmean
Copy link
Contributor Author

@wing328 sure will do it..

@chowmean
Copy link
Contributor Author

@chowmean do you mind filing a PR for https://github.com/OpenAPITools/openapi-generator as well?

I believe eventually we want to replace Swagger Codegen with OpenAPI Generator in this project: kubernetes-client/gen#93

Created the PR. OpenAPITools/openapi-generator#2460

@wing328
Copy link

wing328 commented Mar 23, 2019

UPDATE: OpenAPITools/openapi-generator#2460 has been merged into master. Thanks for the contribution by @chowmean

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 21, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 21, 2019
@chowmean chowmean closed this Jul 22, 2019
@roycaihw
Copy link
Member

Thanks for working on this! The change will be included in this project when kubernetes-client/gen#97 is in place

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants