Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding retries option to override default value 3 of urllib3 #2460

Merged
merged 4 commits into from
Mar 22, 2019

Conversation

chowmean
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Adding retries option to override the default value of urllib which is 3. This will give option to control number of retries for any request.

@wing328
Copy link
Member

wing328 commented Mar 20, 2019

@chowmean thanks for the PR. Can you please also update the Python Petstore samples by running the shell scripts (./bin/python*) or batch files under (bin\windows\python*) ?

@wing328
Copy link
Member

wing328 commented Mar 20, 2019

cc @taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01)

@chowmean
Copy link
Contributor Author

@chowmean thanks for the PR. Can you please also update the Python Petstore samples by running the shell scripts (./bin/python*) or batch files under (bin\windows\python*) ?

Ran the ensure_upto_date which runs all the scripts. I guess that is fine? @wing328

@wing328
Copy link
Member

wing328 commented Mar 22, 2019

Yup, and all tests passed 👍

@wing328 wing328 added this to the 4.0.0 milestone Mar 22, 2019
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants