Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.58] Fix namespace for Machinesets #1793

Merged
merged 1 commit into from
May 6, 2024
Merged

[release/v1.58] Fix namespace for Machinesets #1793

merged 1 commit into from
May 6, 2024

Conversation

kubermatic-bot
Copy link
Contributor

This is an automated cherry-pick of #1792

/assign ahmedwaleedmalik

Fixes a bug where namespace kube-system was hardcoded for finding the MachineDeployment against a Machine

@ahmedwaleedmalik
Fix namespace for machinesets
ef0fbd0 
Signed-off-by: Waleed Malik <[email protected]>
@kubermatic-bot kubermatic-bot mentioned this pull request May 6, 2024
Merged
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 6, 2024
ahmedwaleedmalik
ahmedwaleedmalik approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2024
@kubermatic-bot
Copy link
Contributor Author

LGTM label has been added.

Git tree hash: f08b910cb4fa10dc7cff97ab19f67bbf9d2ff514

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024
ahmedwaleedmalik
ahmedwaleedmalik approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot
Copy link
Contributor Author

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahmedwaleedmalik
Copy link
Member

/retest

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

1 similar comment
@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@ahmedwaleedmalik
Copy link
Member

/retest

@kubermatic-bot kubermatic-bot merged commit dfa65ae into kubermatic:release/v1.58 May 6, 2024
13 checks passed
@kubermatic-bot kubermatic-bot deleted the cherry-pick-1792-to-release/v1.58 branch May 6, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kubermatic-bot @ahmedwaleedmalik @kubermatic-triage-bot