Fix namespace for Machinesets #1792
Conversation
Signed-off-by: Waleed Malik <[email protected]>
kubermatic-bot
added
release-note
|
/cherry-pick release/v1.58 |
|
@ahmedwaleedmalik: once the present PR merges, I will cherry-pick it on top of release/v1.58 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release/v1.57 |
|
@ahmedwaleedmalik: once the present PR merges, I will cherry-pick it on top of release/v1.57 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
LGTM label has been added. Git tree hash: 3be3a4bbde732f6cf0a03cb68b920dd4171a1f1a
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
|
@ahmedwaleedmalik: new pull request created: #1793 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ahmedwaleedmalik: new pull request created: #1794 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release/v1.59 |
|
@ahmedwaleedmalik: new pull request created: #1795 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
When fetching the MachineDeployment against Machine, to propagate user data, we were incorrectly assuming that the namespace would be
kube-system. This is wrong since users can create MD/MS/Machine in any namespace.Which issue(s) this PR fixes:
Fixes #
What type of PR is this?
/kind bug
Special notes for your reviewer:
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation:
/cherry-pick release/v1.59