Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport metrics node provisioning to v1.54 #1575

Merged
merged 2 commits into from
Feb 23, 2023
Merged

Backport metrics node provisioning to v1.54 #1575

merged 2 commits into from
Feb 23, 2023

Conversation

eiabea
Copy link
Contributor

@eiabea eiabea commented Feb 23, 2023

What this PR does / why we need it:

Adds 2 new buckets to the /metrics endpoint about provisioning

  • machine_controller_provisioning_time_seconds
  • machine_controller_deprovisioning_time_seconds

Which issue(s) this PR fixes:

Fixes #1574

What type of PR is this?
/kind feature

Special notes for your reviewer:

golang v1.18 does not have support for .Abs() which broke the backport to release/v1.54 triggered in #1572

This PR fixes this by using time.Since()

Does this PR introduce a user-facing change? Then add your Release Note here:

Added machine_controller_provisioning_time_seconds and machine_controller_deprovisioning_time_seconds metrics to the machine controller

Documentation:

NONE

@eiabea
Add metrics for provisioning nodes
4f0f054 
Add machine_controller_provisioning_time_seconds bucket
Add machine_controller_deprovisioning_time_seconds bucket

Signed-off-by: Manuel Zangl <[email protected]>
@eiabea
Use time.Since instead of time.Until
e6258ea 
Signed-off-by: Manuel Zangl <[email protected]>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. labels Feb 23, 2023
@kubermatic-bot
Copy link
Contributor

Hi @eiabea. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 23, 2023
@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Feb 23, 2023
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a0812f31a6ba6f9af05b6bbe42ff50d4cc1e82dd

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, eiabea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2023
@ahmedwaleedmalik
Copy link
Member

/retest

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@kubermatic-bot kubermatic-bot merged commit dad16d0 into kubermatic:release/v1.54 Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eiabea @kubermatic-bot @ahmedwaleedmalik @kubermatic-triage-bot