-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metrics for provisioning nodes #1572
Add metrics for provisioning nodes #1572
Conversation
Add machine_controller_provisioning_time_seconds bucket Add machine_controller_deprovisioning_time_seconds bucket Signed-off-by: Manuel Zangl <[email protected]>
Hi @eiabea. Thanks for your PR. I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/assign @ahmedwaleedmalik
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thanks for the contribution, it looks great. 🎊
LGTM label has been added. Git tree hash: b40689d983c9d00c032603f6582c6163d11fce18
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, eiabea The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Oh wow, that was fast - nice :) |
@ahmedwaleedmalik thank you for the fast approval! Is it possible to get this PR backported to |
/cherry-pick release/v1.54 |
@ahmedwaleedmalik: new pull request created: #1574 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@eiabea you'll need to manually backport this. The automated backport won't work #1574
v1.54 uses GO 1.18. |
Add machine_controller_provisioning_time_seconds bucket Add machine_controller_deprovisioning_time_seconds bucket Signed-off-by: Manuel Zangl <[email protected]>
What this PR does / why we need it:
Adds 2 new buckets to the
/metrics
endpoint about provisioningWhich issue(s) this PR fixes:
Fixes #1332
What type of PR is this?
/kind feature
Special notes for your reviewer:
As previously discussed in the ticket #1332 here is our announced PR
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: