Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics for provisioning nodes #1572

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

eiabea
Copy link
Contributor

@eiabea eiabea commented Feb 22, 2023

What this PR does / why we need it:

Adds 2 new buckets to the /metrics endpoint about provisioning

  • machine_controller_provisioning_time_seconds
  • machine_controller_deprovisioning_time_seconds

Which issue(s) this PR fixes:

Fixes #1332

What type of PR is this?
/kind feature

Special notes for your reviewer:

As previously discussed in the ticket #1332 here is our announced PR

Does this PR introduce a user-facing change? Then add your Release Note here:

Added machine_controller_provisioning_time_seconds and machine_controller_deprovisioning_time_seconds metrics to the machine controller

Documentation:

NONE

Add machine_controller_provisioning_time_seconds bucket
Add machine_controller_deprovisioning_time_seconds bucket

Signed-off-by: Manuel Zangl <[email protected]>
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 22, 2023
@kubermatic-bot
Copy link
Contributor

Hi @eiabea. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 22, 2023
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test
/assign @ahmedwaleedmalik

@kubermatic-bot kubermatic-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 22, 2023
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks for the contribution, it looks great. 🎊

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 22, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b40689d983c9d00c032603f6582c6163d11fce18

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, eiabea

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 22, 2023
@kubermatic-bot kubermatic-bot merged commit d710662 into kubermatic:main Feb 22, 2023
@LittleFox94
Copy link
Contributor

Oh wow, that was fast - nice :)

@eiabea
Copy link
Contributor Author

eiabea commented Feb 23, 2023

@ahmedwaleedmalik thank you for the fast approval! Is it possible to get this PR backported to 1.54?

@ahmedwaleedmalik
Copy link
Member

/cherry-pick release/v1.54

@kubermatic-bot
Copy link
Contributor

@ahmedwaleedmalik: new pull request created: #1574

In response to this:

/cherry-pick release/v1.54

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahmedwaleedmalik
Copy link
Member

ahmedwaleedmalik commented Feb 23, 2023

@eiabea you'll need to manually backport this. The automated backport won't work #1574

github.com/kubermatic/machine-controller/pkg/cloudprovider
github.com/kubermatic/machine-controller/pkg/controller/machine
# github.com/kubermatic/machine-controller/pkg/controller/machine
pkg/controller/machine/machine_controller.go:470:76: time.Until(machine.CreationTimestamp.Time).Abs undefined (type time.Duration has no field or method Abs)
pkg/controller/machine/machine_controller.go:613:78: time.Until(machine.DeletionTimestamp.Time).Abs undefined (type time.Duration has no field or method Abs)

v1.54 uses GO 1.18.

eiabea added a commit to anexia-it/machine-controller that referenced this pull request May 8, 2023
Add machine_controller_provisioning_time_seconds bucket
Add machine_controller_deprovisioning_time_seconds bucket

Signed-off-by: Manuel Zangl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

re-add the metric node_join_duration
4 participants