Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.45] Use new vSphere preset #1502

Closed
wants to merge 1 commit into from
Closed

[release/v1.45] Use new vSphere preset #1502

wants to merge 1 commit into from

Conversation

embik
Copy link
Member

@embik embik commented Nov 30, 2022

What this PR does / why we need it:
This PR tries to restore vSphere test functionality by using the ne vSphere preset.

Which issue(s) this PR fixes:

Fixes #

What type of PR is this?
/kind cleanup
/kind failing-test

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

NONE

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. labels Nov 30, 2022
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 30, 2022
@ahmedwaleedmalik
Copy link
Member

Can we apply this change to #1488 instead? Without doing that tests on both these PRs will fail.

@embik
Copy link
Member Author

embik commented Nov 30, 2022

Can we apply this change to #1488 instead? Without doing that tests on both these PRs will fail.

Fair point. Let me reach out to @dermorz.

@embik embik closed this Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. release-note-none Denotes a PR that doesn't merit a release note. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@embik @kubermatic-bot @ahmedwaleedmalik