Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.45] Update filter for CentOS Linux images #1488

Merged
merged 4 commits into from
Dec 8, 2022
Merged

[release/v1.45] Update filter for CentOS Linux images #1488

merged 4 commits into from
Dec 8, 2022

Conversation

dermorz
Copy link
Contributor

@dermorz dermorz commented Nov 16, 2022

What this PR does / why we need it:
CentOS changed their image names in a way our filters did not match anymore: https://wiki.centos.org/Cloud/AWS

Does this PR introduce a user-facing change? Then add your Release Note here:

Update CentOS AMI filter

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 16, 2022
@dermorz dermorz changed the title Backport centos image filters to 1.45 [release/v1.45] Update filter for CentOS Linux images Nov 16, 2022
@kubermatic-bot kubermatic-bot added sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 16, 2022
@mate4st
Copy link
Contributor

mate4st commented Nov 22, 2022

/retest

ahmedwaleedmalik
ahmedwaleedmalik approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0836a9f1cd4eb1822574e3e6c7db8a6422a78f8c

@ahmedwaleedmalik
Copy link
Member

/retest

2 similar comments
@mate4st
Copy link
Contributor

mate4st commented Nov 28, 2022

/retest

@mate4st
Copy link
Contributor

mate4st commented Nov 29, 2022

/retest

@mate4st
Copy link
Contributor

mate4st commented Nov 29, 2022

@dermorz the vcenter url is wrong. Its pointing to "vcenter.qa.lab.kubermatic.io"

@ahmedwaleedmalik ahmedwaleedmalik mentioned this pull request Nov 30, 2022
Closed
@dermorz
Use new vSphere preset
3d0c0d0 
Signed-off-by: Moritz Bracht <[email protected]>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 30, 2022
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 30, 2022
@dermorz
Copy link
Contributor Author

dermorz commented Nov 30, 2022

/retest

2 similar comments
@embik
Copy link
Member

embik commented Dec 1, 2022

/retest

@ahmedwaleedmalik
Copy link
Member

/retest

@embik
Copy link
Member

embik commented Dec 7, 2022

/retest

@embik
Copy link
Member

embik commented Dec 7, 2022

/retest

embik
embik approved these changes Dec 7, 2022
View reviewed changes
Copy link
Member

@embik embik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 7, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d4be7b8d630b405d911ba4fe23a8d85f6bd9c705

@embik
Copy link
Member

embik commented Dec 8, 2022

/retest

@xrstf
Copy link
Contributor

xrstf commented Dec 8, 2022

/override pull-machine-controller-e2e-nutanix
/override pull-machine-controller-e2e-vsphere

@kubermatic-bot
Copy link
Contributor

@xrstf: Overrode contexts on behalf of xrstf: pull-machine-controller-e2e-nutanix, pull-machine-controller-e2e-vsphere

In response to this:

/override pull-machine-controller-e2e-nutanix
/override pull-machine-controller-e2e-vsphere

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ahmedwaleedmalik
Copy link
Member

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, dermorz, embik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 8, 2022
@kubermatic-bot kubermatic-bot merged commit 3056343 into kubermatic:release/v1.45 Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik approved these changes

@ahmedwaleedmalik ahmedwaleedmalik Awaiting requested review from ahmedwaleedmalik

Assignees

@embik embik

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cluster-management Denotes a PR or issue as being assigned to SIG Cluster Management. sig/osm Denotes a PR or issue as being assigned to SIG OSM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dermorz @mate4st @kubermatic-bot @ahmedwaleedmalik @embik @xrstf