Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix slack deprecation notice #382

Merged
merged 1 commit into from
May 31, 2021
Merged

fix slack deprecation notice #382

merged 1 commit into from
May 31, 2021

Conversation

dkulchinsky
Copy link
Contributor

@dkulchinsky dkulchinsky commented May 28, 2021 •
edited by dholbach
Loading

fixes #381

@dkulchinsky dkulchinsky mentioned this pull request May 28, 2021
Closed
@dholbach dholbach added this to the 1.8.0 milestone May 29, 2021
dholbach
dholbach approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@dholbach dholbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @dkulchinsky!

@dholbach dholbach merged commit 807b727 into kubereboot:main May 31, 2021
@ckotzbauer ckotzbauer mentioned this pull request Sep 30, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dholbach dholbach dholbach approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

Deprecation warning is always printed, even when slack-* cli args are not used
2 participants
@dkulchinsky @dholbach