Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated flag(s). Please use --notify-url flag instead. #409

Closed
Tetradeus opened this issue Jul 20, 2021 · 9 comments · Fixed by #368
Closed

Deprecated flag(s). Please use --notify-url flag instead. #409

Tetradeus opened this issue Jul 20, 2021 · 9 comments · Fixed by #368
Assignees
Milestone

Comments

@Tetradeus
Copy link

When using last helm version (2.7.1) and setting value in 'configuration.notifyUrl', we get a deprecation message in kured pods :

time="2021-07-20T08:55:06Z" level=warning msg="Deprecated flag(s). Please use --notify-url flag instead."
@ckotzbauer ckotzbauer self-assigned this Jul 26, 2021
@anderius
Copy link

anderius commented Aug 10, 2021

I am experiencing the same with Helm chart version 2.9.0.

(EDIT: I was using another slack parameter. The unreleased warning message fix will fix this confusion)

@ckotzbauer
Copy link
Member

@Tetradeus Do you use the --slack-channel, --slack-hook-url or --slack-username flag (in addition to the --notify-url?
Then this message is emitted, as the slack-flags are deprecated and should not be used together with the new --notify-url parameter from shoutrrr.

@jgilfoil
Copy link

jgilfoil commented Sep 30, 2021

I'm getting this issue on chart version 2.9.1

    configuration:
      timeZone: "America/New_York"
      startTime: "4:00"
      endTime: "10:00"
      notifyUrl: "${SECRET_KURED_DISCORD_WEBHOOK}"
      messageTemplateDrain: "⏳ Draining node %s"
      messageTemplateReboot: "♻️ Rebooted node %s"
      rebootCommand: "/usr/bin/systemctl reboot"

time="2021-09-30T00:55:10Z" level=warning msg="Deprecated flag(s). Please use --notify-url flag instead."

edit:
here's the args as pulled from kubectl describe pod:

    Args:
      --ds-name=kured
      --ds-namespace=kube-system
      --end-time=10:00
      --reboot-command=/usr/bin/systemctl reboot
      --notify-url=<redacted>
      --message-template-drain=⏳ Draining node %s
      --message-template-reboot=♻️ Rebooted node %s
      --start-time=4:00
      --time-zone=America/New_York

@ckotzbauer
Copy link
Member

This misleading warning was fixed with #382 and will be released in a few days with the upcoming release (1.8.0).
The --slack-username parameter has a default-value, so the warning appeared even if you don't set a --slack* parameter by yourself.

@Tetradeus
Copy link
Author

Hello @ckotzbauer ,

Sorry for my late reply. I do not use slack nor any slack specific parameters.
I only use notify url via the helm chart setting value 'configuration.notifyUrl',

Thanks.

@Tetradeus
Copy link
Author

Here is the limited computed values I see in my helm chart release :

configuration:
  alertFilterRegexp: ""
  annotateNodes: false
  blockingPodSelector: []
  endTime: "04:00"
  lockAnnotation: ""
  lockReleaseDelay: 0
  lockTtl: 0
  messageTemplateDrain: ""
  messageTemplateReboot: ""
  notifyUrl: teams://xxxxx
  period: 1h0m0s
  prometheusUrl: ""
  rebootCommand: /bin/systemctl reboot
  rebootDays:
  - sun
  rebootSentinel: ""
  slackChannel: ""
  slackHookUrl: ""
  slackUsername: ""

Is the slackUsername default value "" ? Is this causing the warning ? Thanks.

@ckotzbauer
Copy link
Member

configuration.slackUsername: "" causes the helm-chart not to add the flag to the daemonset. So (from kured's perspective) the --slack-username parameter is not set, which causes the fallback in main.go to take effect.

@ckotzbauer
Copy link
Member

fyi: The warning fix is postponed to 1.8.1

@ckotzbauer ckotzbauer added this to the 1.8.1 milestone Oct 8, 2021
@dholbach
Copy link
Member

dholbach commented Dec 6, 2021

We believe this has been fixed in #368 - please reopen if this is still an issue.

@dholbach dholbach closed this as completed Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants