Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GCP] Update docs for private clusters and VPC service controls for 1.0 #1705

Closed
jlewi opened this issue Feb 19, 2020 · 14 comments · Fixed by #2190
Closed

[GCP] Update docs for private clusters and VPC service controls for 1.0 #1705

jlewi opened this issue Feb 19, 2020 · 14 comments · Fixed by #2190
Assignees
@zhenghuiwang
Labels
area/docs kind/bug platform/gcp priority/p1

Comments

@jlewi
Copy link
Contributor

jlewi commented Feb 19, 2020

The docs on using VPC Service controls to secure Kubeflow on GCP need to be updated.
https://www.kubeflow.org/docs/gke/private-clusters/#enable-vpc-service-controls-in-your-project

Related issues:

kubeflow/kubeflow#3210 - Replicating images to private GKE
kubeflow/kubeflow#3650 - ISTIO on private GKE
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/bug 0.70

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@jlewi jlewi mentioned this issue Feb 19, 2020
Closed
@sarahmaddox
Copy link
Contributor

Related: #1769

@sarahmaddox sarahmaddox changed the title [GCP] Update Docs for VPC Service controls for 1.0 [GCP] Update docs for private clusters and VPC service controls for 1.0 Mar 4, 2020
@sarahmaddox
Copy link
Contributor

/assign @zhenghuiwang

@zhenghuiwang I'm assigning this to you, as I understand you're working on a solution for the config of private clusters. Let me know when you're ready to work with me on the updating of the website docs. We'll take a look and decide whether we need more than one doc, based on your findings.

@sarahmaddox
Copy link
Contributor

Related: #1811

@sarahmaddox sarahmaddox mentioned this issue Mar 16, 2020
Closed
@sarahmaddox
Copy link
Contributor

This PR proposes an update to the private clusters page too: #1563
There hasn't been any activity on the PR for a while. It may be worth checking in with the author.

@sarahmaddox sarahmaddox mentioned this issue Mar 20, 2020
Closed
jlewi pushed a commit to jlewi/website that referenced this issue Apr 8, 2020
Private GKE: Document image mirroring
0c1da8e 
* Add instructions for mirroring docker images to private repositories
  * Fix kubeflow/kubeflow#3210

* Delete instructions under private GKE and just link to the doc issue kubeflow#1705

  * The instructions are outdated. Since managed certificates are used there
    should be no reason to need to update iap-ingress.yaml anymore.
    * Fix kubeflow#1811

  * Most of the other instructions under the private GKE section are also
    very obsolete.
@jlewi jlewi mentioned this issue Apr 8, 2020
Merged
k8s-ci-robot pushed a commit that referenced this issue Apr 8, 2020
@jlewi
Private GKE: Document image mirroring (#1886)
42cbd8b 
* Private GKE: Document image mirroring

* Add instructions for mirroring docker images to private repositories
  * Fix kubeflow/kubeflow#3210

* Delete instructions under private GKE and just link to the doc issue #1705

  * The instructions are outdated. Since managed certificates are used there
    should be no reason to need to update iap-ingress.yaml anymore.
    * Fix #1811

  * Most of the other instructions under the private GKE section are also
    very obsolete.

* Fix indentation.

* Fix indetation.

* Fix indentation.

* Fix alert.

* More formatting fixes.

* Add comment about Tekton.
@jlewi jlewi mentioned this issue Apr 11, 2020
Merged
@jbottum
Copy link
Contributor

jbottum commented May 21, 2020

@zhenghuiwang Hi Zhenghui - We have two users (US Bank and Raymond James) who are tracking this development. Will this be available in Kubeflow 1.1? Should we set-up a meeting to discuss the status with the potential users?

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/docs 0.90

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@jlewi
Copy link
Contributor Author

jlewi commented May 24, 2020

@zhenghuiwang isnt working on this.

We are trying to get docs for using VPC-SC with blueprints ready for 1.1. I give it about 50% confidence that it will land for 1.1

@jlewi
Copy link
Contributor Author

jlewi commented May 24, 2020

Related issue: kubeflow/pipelines#3347

@jlewi
Copy link
Contributor Author

jlewi commented Jun 15, 2020

Updated docs are here:
https://github.com/kubeflow/gcp-blueprints/blob/master/kubeflow/deploy_private.md

We either need to copy this over to the website or update the website to point at those docs.

@8bitmp3
Copy link
Contributor

8bitmp3 commented Jun 15, 2020

@jlewi I can assist with updating the site (Hugo). Copying it over makes sense, so there's less clicks/friction in terms of user experience. cc @sarahmaddox

@stale
Copy link

stale bot commented Sep 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@8bitmp3
Copy link
Contributor

8bitmp3 commented Sep 13, 2020

@Bobgy

Guide: "How to secure Kubeflow clusters using VPC service controls and private GKE"

If you have time, can you help me figure our what needs to go and what can stay? Cheers!!

@stale stale bot removed the lifecycle/stale label Sep 13, 2020
jlewi pushed a commit to jlewi/website that referenced this issue Sep 14, 2020
Update the docs for private GKE.
8af75d8 
* Replace the instructions for private GKE with the instructions from the
  repo: https://github.com/kubeflow/gcp-blueprints/blob/master/kubeflow/deploy_private.md

* fix: kubeflow#1705
@jlewi jlewi mentioned this issue Sep 14, 2020
Merged
jlewi pushed a commit to jlewi/gcp-blueprints that referenced this issue Sep 14, 2020
Move the private GKE docs to the website.
f35d6e0 
Related to kubeflow/website#1705
@jlewi jlewi mentioned this issue Sep 14, 2020
Merged
@8bitmp3
Copy link
Contributor

8bitmp3 commented Sep 14, 2020

Thanks @jlewi #2190

jlewi pushed a commit to jlewi/website that referenced this issue Sep 14, 2020
Update the docs for private GKE.
ae7bbdd 
* Replace the instructions for private GKE with the instructions from the
  repo: https://github.com/kubeflow/gcp-blueprints/blob/master/kubeflow/deploy_private.md

* fix: kubeflow#1705
k8s-ci-robot pushed a commit that referenced this issue Sep 22, 2020
@jlewi @8bitmp3
Update the docs for private GKE. (#2190)
c59e3ae 
* Update the docs for private GKE.

* Replace the instructions for private GKE with the instructions from the
  repo: https://github.com/kubeflow/gcp-blueprints/blob/master/kubeflow/deploy_private.md

* fix: #1705

* Update content/en/docs/gke/private-clusters.md

Co-authored-by: 8bitmp3 <[email protected]>

* Update content/en/docs/gke/private-clusters.md

Co-authored-by: 8bitmp3 <[email protected]>

* Update content/en/docs/gke/private-clusters.md

Co-authored-by: 8bitmp3 <[email protected]>

* Address comments.

* Update the Anthos docs to point to the relevant GitHub issue.

* Add some fullstops.

* Update content/en/docs/gke/private-clusters.md

Co-authored-by: 8bitmp3 <[email protected]>

* Update content/en/docs/gke/private-clusters.md

Co-authored-by: 8bitmp3 <[email protected]>

* Update content/en/docs/gke/private-clusters.md

Co-authored-by: 8bitmp3 <[email protected]>

* Update content/en/docs/gke/private-clusters.md

Co-authored-by: 8bitmp3 <[email protected]>

* Update content/en/docs/gke/private-clusters.md

Co-authored-by: 8bitmp3 <[email protected]>

* Update content/en/docs/gke/private-clusters.md

Co-authored-by: 8bitmp3 <[email protected]>

* Update content/en/docs/gke/private-clusters.md

Co-authored-by: 8bitmp3 <[email protected]>

* Update content/en/docs/gke/private-clusters.md

Co-authored-by: 8bitmp3 <[email protected]>

* More fixes.

Co-authored-by: 8bitmp3 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zhenghuiwang zhenghuiwang

Labels
area/docs kind/bug platform/gcp priority/p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the docs for private GKE. jlewi/website
5 participants
@jlewi @sarahmaddox @zhenghuiwang @jbottum @8bitmp3