Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the private GKE docs to the website. #136

Merged
merged 1 commit into from
Oct 22, 2020

Conversation

jlewi
Copy link
Contributor

@jlewi jlewi commented Sep 14, 2020

@kubeflow-bot
Copy link

This change is Reviewable

@jlewi
Copy link
Contributor Author

jlewi commented Sep 14, 2020

/assign @Bobgy

@jlewi
Copy link
Contributor Author

jlewi commented Sep 14, 2020

@Bobgy
Copy link
Contributor

Bobgy commented Sep 16, 2020

/hold
/lgtm
We should merge after the website PR is merged

@jlewi
Copy link
Contributor Author

jlewi commented Oct 20, 2020

Website PR has been merged.

/hold cancel

@Bobgy
Copy link
Contributor

Bobgy commented Oct 22, 2020

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy, jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

@jlewi: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-gcp-blueprints-presubmit f35d6e0 link /test kubeflow-gcp-blueprints-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jlewi
Copy link
Contributor Author

jlewi commented Oct 22, 2020

Merging manually since this isn't related to the test failure.

@jlewi jlewi merged commit 7ed4077 into GoogleCloudPlatform:master Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants