Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update initialClusterVersion to 1.7.11-gke.1 #269

Merged
merged 3 commits into from
Jan 8, 2018
Merged

update initialClusterVersion to 1.7.11-gke.1 #269

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c41d9fb
update initialClusterVersion to 1.7.11-gke.1
Jan 7, 2018
184d2a0
revert linter-related changes
Jan 7, 2018
c538264
set initialClusterVersion to 1.8.5-gke.0
Jan 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion py/deploy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def setup(args):
],
},
# TODO(jlewi): Stop pinning GKE version once 1.8 becomes the default.
"initialClusterVersion": "1.8.1-gke.1",
"initialClusterVersion": "1.7.11-gke.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be using 1.8. for CRD and GPU support.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool it looks from gcloud container get-server-config that '1.8.5-gke.0' and '1.8.4-gke.1' are the two 1.8+ versions supported. Preference?

}
}

Expand All @@ -70,6 +70,10 @@ def setup(args):

util.setup_cluster(api_client)

# A None gcs_client should be passed to test_util.create_junit_xml_file
# unless chart.startswith("gs://"), e.g. https://storage.googleapis.com/...
gcs_client = None

if chart.startswith("gs://"):
remote = chart
chart = os.path.join(tempfile.gettempdir(), os.path.basename(chart))
Expand Down