Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update initialClusterVersion to 1.7.11-gke.1 #269

Merged
merged 3 commits into from
Jan 8, 2018
Merged

update initialClusterVersion to 1.7.11-gke.1 #269

merged 3 commits into from
Jan 8, 2018

Conversation

cwbeitel
Copy link
Contributor

@cwbeitel cwbeitel commented Jan 7, 2018 •
edited by jlewi
Loading

This change is Reviewable

cwbeitel added 2 commits January 7, 2018 08:43
update initialClusterVersion to 1.7.11-gke.1
c41d9fb 
- addressing kubeflow#268
- previously thought GCS read/write was also necessary for tensorflow/agents
  but does not appear to be the case so oauthScopes left unchanged.
revert linter-related changes
184d2a0
@k8s-ci-robot
Copy link

Hi @cwbeitel. Thanks for your PR.

I'm waiting for a kubernetes or tensorflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

coveralls commented Jan 7, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 28.374% when pulling 184d2a0 on cwbeitel:master into 190394d on tensorflow:master.

jlewi
jlewi reviewed Jan 7, 2018
View reviewed changes
py/deploy.py Outdated
@@ -45,7 +45,7 @@ def setup(args):
],
},
# TODO(jlewi): Stop pinning GKE version once 1.8 becomes the default.
"initialClusterVersion": "1.8.1-gke.1",
"initialClusterVersion": "1.7.11-gke.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be using 1.8. for CRD and GPU support.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool it looks from gcloud container get-server-config that '1.8.5-gke.0' and '1.8.4-gke.1' are the two 1.8+ versions supported. Preference?

@coveralls
Copy link

coveralls commented Jan 8, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 28.374% when pulling c538264 on cwbeitel:master into 190394d on tensorflow:master.

@jlewi jlewi merged commit 13db0a5 into kubeflow:master Jan 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlewi jlewi jlewi approved these changes

Assignees
No one assigned
Labels
needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cwbeitel @k8s-ci-robot @coveralls @jlewi