Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set timeout and interval to all Eventually tests #1846

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Jul 3, 2023

What this PR does / why we need it:
I modified all Eventually tests to fix flaky tests:

  1. Commonize timeout and interval.
  2. Set timeout and interval to all Eventually tests

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #1820
Fixes: #1822
Fixes: #1844
Related to #1816

Checklist:

  • Docs included if any changes are user facing

@coveralls
Copy link

coveralls commented Jul 3, 2023

Pull Request Test Coverage Report for Build 5448573469

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 33.665%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob_controller.go 4 79.22%
Totals Coverage Status
Change from base Build 5448290334: -0.04%
Covered Lines: 3281
Relevant Lines: 9746

💛 - Coveralls

@tenzen-y tenzen-y force-pushed the commonize-timeout branch from cab8cf3 to f3a0d0f Compare July 3, 2023 21:11
@tenzen-y
Copy link
Member Author

tenzen-y commented Jul 3, 2023

/assign @terrytangyuan @johnugeorge

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jul 4, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit bb628c4 into kubeflow:master Jul 4, 2023
@tenzen-y tenzen-y deleted the commonize-timeout branch July 4, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants