Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix argo uri #62

Merged
merged 1 commit into from
Mar 13, 2018
Merged

fix argo uri #62

merged 1 commit into from
Mar 13, 2018

Conversation

jimexist
Copy link
Member

for now the timeline url path gave me a blank line everytime i want to access the build job. using workflows renders the correct result.

also the tab is a query (i.e. follows a ?)

@jimexist
Copy link
Member Author

jimexist commented Mar 13, 2018

/cc @jlewi
/cc @gaocegege
/cc @ScorpioCPH
/cc @lluunn

@jimexist
Copy link
Member Author

jimexist commented Mar 13, 2018

some more background:

i was trying to see why this failed, which gave this link and then this url, correcting it to this URL instead gives me the correct page.

However, as you see the log here it still shows something inactionable for me...

{
  "apiVersion": "v1",
  "code": 404,
  "details": {
    "kind": "pods",
    "name": "kubeflow-tf-operator-presubmit-tfjob-e2e-439-51b7054-183-1ae8-2797052290"
  },
  "kind": "Status",
  "message": "pods \"kubeflow-tf-operator-presubmit-tfjob-e2e-439-51b7054-183-1ae8-2797052290\" not found",
  "metadata": {},
  "reason": "NotFound",
  "status": "Failure"
}

@jlewi or @lluunn do you mind taking a look?

@ScorpioCPH
Copy link
Member

Thanks!
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ScorpioCPH

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit dac49bf into kubeflow:master Mar 13, 2018
@jimexist jimexist deleted the correct-argo-uri branch March 13, 2018 07:30
jimexist added a commit to jimexist/testing that referenced this pull request Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants