Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL for Argo workflows changed #60

Closed
jlewi opened this issue Mar 8, 2018 · 4 comments
Closed

URL for Argo workflows changed #60

jlewi opened this issue Mar 8, 2018 · 4 comments
Assignees

Comments

@jlewi
Copy link
Contributor

jlewi commented Mar 8, 2018

In gubernator we report the url for the worfklow UI as

http://testing-argo.kubeflow.org/workflows/kubeflow-test-infra/kubeflow-presubmit-tf-serving-image-387-f608b1a-532-1c41;tab=workflow

This doesn't appear to be valid anymore with the new version of the Argo UI.

I think we just want to use

http://testing-argo.kubeflow.org/workflows/kubeflow-test-infra/kubeflow-presubmit-tf-serving-image-387-f608b1a-532-1c41

@jimexist would you mind sending another PR to fix this?

@jimexist
Copy link
Member

@jlewi i updated it in #62

@jimexist
Copy link
Member

if you can confirm that this issue is fixed by that PR it'll be great, thanks!

@jlewi
Copy link
Contributor Author

jlewi commented Mar 19, 2018

This doesn't appear to be fixed.
https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/kubeflow_testing/62/kubeflow-testing-presubmit/77/

Still reports as the workflow
http://testing-argo.kubeflow.org/workflows/kubeflow-test-infra/kubeflow-presubmit-tf-serving-image-445-bcec1a8-681-30cc?tab=workflow

We most likely need to rebuild the testing image since run_e2e_workflow.py is built into the test container.

@jlewi
Copy link
Contributor Author

jlewi commented Mar 19, 2018

I take that back run_e2e_workflow.py should be checked out from kubeflow/testing via checkout.sh.

And the URLs now appear to work. Marking this as fixed.

@jlewi jlewi closed this as completed Mar 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants