-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use 2to3 to convert from Python2 to 3 and use yapf to reformat #35
Conversation
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
the benefit / cost for this PR is a bit low so it is really low priority for now. I am just submitting for view only. |
Please sync. Can you pick a reviewer (other than me :)) I'd like to start spreading the review workload around. |
to be merged after #36 |
/assign @gaocegege |
seems like the presubmit job is a bit unstable for now |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@jimexist If you see that error
It typically means the prow job didn't make it as far as actually uploading any results to GCS. So typically in this case you can trigger the test and then look for the job in the prow job dashboard. From there you can grab the actual pod logs. These get garbage collected pretty soon after the job finishes so you need to try to catch it in the act. |
Here's the link to the prow jobs dashboard |
/test all |
1 similar comment
/test all |
/test all |
1 similar comment
/test all |
… process. (kubeflow#47) We want to use a different image for security reasons because test code running in the test project could potentially modify the test worker image. To deal with kubeflow#46 remove hashes from requirements.txt
* fix * use ks 0.9.1
* Replace sha256sum because it doesn't work on OSX
Most likely that means there is a problem running the workflow and it never gets far enough to upload the results to GCS. You need to try to look at the pod logs for the test; these are ephmeral so you need to grab them shortly after running your job. You can find them here |
@jlewi maybe due to lack of authorization, what i saw in https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/kubeflow_testing/35/kubeflow-testing-presubmit/99/ was:
|
I was able to get access to the logs. Here's the failure
|
/retest |
@jimexist: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
see #86 in leu of |
low priority
use:
yapf
to auto format code