Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate CRD specs, bump to v1beta2 #578

Merged
merged 9 commits into from
Sep 13, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Tweak Cores validation
Kevin Hogeland committed Sep 6, 2019
commit 76906516318e7f85d9b9ff8014c56046245e32dc
Original file line number Diff line number Diff line change
@@ -356,9 +356,8 @@ spec:
coreLimit:
type: string
cores:
exclusiveMinimum: true
format: int32
minimum: 0
minimum: 1
type: integer
dnsConfig:
properties:
@@ -1245,9 +1244,8 @@ spec:
coreRequest:
type: string
cores:
exclusiveMinimum: true
format: int32
minimum: 0
minimum: 1
type: integer
dnsConfig:
properties:
6 changes: 2 additions & 4 deletions manifest/crds/sparkoperator.k8s.io_sparkapplications.yaml
Original file line number Diff line number Diff line change
@@ -342,9 +342,8 @@ spec:
coreLimit:
type: string
cores:
exclusiveMinimum: true
format: int32
minimum: 0
minimum: 1
type: integer
dnsConfig:
properties:
@@ -1231,9 +1230,8 @@ spec:
coreRequest:
type: string
cores:
exclusiveMinimum: true
format: int32
minimum: 0
minimum: 1
type: integer
dnsConfig:
properties:
3 changes: 1 addition & 2 deletions pkg/apis/sparkoperator.k8s.io/v1beta2/types.go
Original file line number Diff line number Diff line change
@@ -358,8 +358,7 @@ type Dependencies struct {
type SparkPodSpec struct {
// Cores is the number of CPU cores to request for the pod.
// Optional.
// +kubebuilder:validation:Minimum=0
// +kubebuilder:validation:ExclusiveMinimum=true
// +kubebuilder:validation:Minimum=1
Cores *int32 `json:"cores,omitempty"`
// CoreLimit specifies a hard limit on CPU cores for the pod.
// Optional