Generate CRD specs, bump to v1beta2 #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase. I will need to cut a final release for |
|
Might be a good time to consider finalizing this PR |
|
Can you rebase this? |
added 2 commits
September 5, 2019 14:54
liyinan926
reviewed
Sep 5, 2019
liyinan926
reviewed
Sep 10, 2019
|
@khogeland have you been running this version in production? |
|
We haven't, it seems too far-reaching (i.e. too likely to turn into a merge conflict nightmare) to maintain in an internal fork. |
|
All right. Please fix the remaining typo and I will merge this. |
|
Any more commits coming? If no, will merge soon. |
|
Nope, that should be the last of them. |
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
* Generate CRD specs, bump to v1beta2 * Add short/singular CRD names * Merge upstream/master * Tweak Cores validation * Fix typo, merge upstream * Update remaining docs for v1beta2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current, manually-defined CRD validation is really unsafe, which we just learned of due to an outage:
This PR replaces the manually written CRD specs with ones generated by the controller-gen tool (part of Kubebuilder). It also gets rid of CRD self-registration, because there is no CRD Go code generated (I explored bundling the generated YAML, but it would be a hack and doesn't seem that useful).
Also bumped the version because this is a backwards-incompatible change:
Coresfield fromfloat32toint32, because Spark parses it as an integer, and controller-gen doesn't support floatsExisting validation has been migrated over, with the exception of the
metadata.namefield length, because I can't put annotations on a field from k8s. I'd like to figure out how to get that validation back, currently it'll fail at spark-submit.I'm pretty sure I missed a few things when bumping the version, and some docs are now out of date, so I'll clean that up asap. Sorry I'm dumping another large PR on you without warning!