Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): Allow empty namespace in pipelines. Fixes #8840. #8859

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

gkcalat
Copy link
Member

@gkcalat gkcalat commented Feb 15, 2023

Description of your changes:

  • Removed namespace validation when converting to v2 API pipeline message

Checklist:

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gkcalat
Copy link
Member Author

gkcalat commented Feb 15, 2023

/test all

@gkcalat gkcalat marked this pull request as ready for review February 15, 2023 22:48
Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Feb 16, 2023
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 03b7752 into kubeflow:master Feb 16, 2023
jlyaoyuli pushed a commit to jlyaoyuli/pipelines that referenced this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants