fix(backend): Allow empty namespace in pipelines. Fixes #8840. (#8859)

kubeflow · Feb 16, 2023 · 03b7752 · 03b7752
1 parent 1e1a020
commit 03b7752
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 26 deletions.
diff --git a/backend/src/apiserver/server/api_converter.go b/backend/src/apiserver/server/api_converter.go
@@ -280,18 +280,6 @@ func toApiPipeline(pipeline *model.Pipeline) *apiv2beta1.Pipeline {
 		}
 	}
 
-	if pipeline.Namespace == "" {
-		return &apiv2beta1.Pipeline{
-			PipelineId: pipeline.UUID,
-			Error: util.ToRpcStatus(
-				util.NewInternalServerError(
-					errors.New("Pipeline namespace cannot be empty"),
-					"Failed to convert a pipeline to API pipeline",
-				),
-			),
-		}
-	}
-
 	return &apiv2beta1.Pipeline{
 		PipelineId:  pipeline.UUID,
 		DisplayName: pipeline.Name,

diff --git a/backend/src/apiserver/server/api_converter_test.go b/backend/src/apiserver/server/api_converter_test.go
@@ -1090,13 +1090,10 @@ func TestToApiPipeline(t *testing.T) {
 				CreatedAtInSec: 1,
 			},
 			&apiv2beta1.Pipeline{
-				PipelineId: "p1",
-				Error: util.ToRpcStatus(
-					util.NewInternalServerError(
-						errors.New("Pipeline namespace cannot be empty"),
-						"Failed to convert a pipeline to API pipeline",
-					),
-				),
+				PipelineId:  "p1",
+				DisplayName: "pipeline1",
+				Description: "This is pipeline1",
+				CreatedAt:   &timestamppb.Timestamp{Seconds: 1},
 			},
 		},
 	}
@@ -1187,13 +1184,10 @@ func TestToApiPipelines(t *testing.T) {
 			),
 		},
 		{
-			PipelineId: "p1",
-			Error: util.ToRpcStatus(
-				util.NewInternalServerError(
-					errors.New("Pipeline namespace cannot be empty"),
-					"Failed to convert a pipeline to API pipeline",
-				),
-			),
+			PipelineId:  "p1",
+			DisplayName: "pipeline1",
+			Description: "This is pipeline1",
+			CreatedAt:   &timestamppb.Timestamp{Seconds: 1},
 		},
 	}
 	assert.Equal(t, expectedPipelines, apiPipelines)