Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): Upgrade mysql to 8.0.26 #8351

Merged
merged 6 commits into from
Oct 14, 2022
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .cloudbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ steps:
args: ['pull', 'gcr.io/ml-pipeline/minio:RELEASE.2019-08-14T20-37-41Z-license-compliance']
id: 'pullMinio'
- name: 'gcr.io/cloud-builders/docker'
args: ['pull', 'gcr.io/ml-pipeline/mysql:5.7-debian']
args: ['pull', 'gcr.io/ml-pipeline/mysql:8.0.26']
id: 'pullMysql'
- name: 'gcr.io/cloud-builders/docker'
args: ['pull', 'gcr.io/cloudsql-docker/gce-proxy:1.25.0']
Expand Down
10 changes: 5 additions & 5 deletions .release.cloudbuild.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -432,14 +432,14 @@ steps:
docker push gcr.io/ml-pipeline/google/pipelines-test/minio:$(cat /workspace/mm.ver)

- name: 'gcr.io/cloud-builders/docker'
args: ['pull', 'gcr.io/ml-pipeline/mysql:5.7-debian']
args: ['pull', 'gcr.io/ml-pipeline/mysql:8.0.26']
id: 'pullMysql'
- name: 'gcr.io/cloud-builders/docker'
args: ['tag', 'gcr.io/ml-pipeline/mysql:5.7-debian', 'gcr.io/ml-pipeline/google/pipelines/mysql:$TAG_NAME']
args: ['tag', 'gcr.io/ml-pipeline/mysql:8.0.26', 'gcr.io/ml-pipeline/google/pipelines/mysql:$TAG_NAME']
id: 'tagMySqlForMarketplace'
waitFor: ['pullMysql']
- name: 'gcr.io/cloud-builders/docker'
args: ['tag', 'gcr.io/ml-pipeline/mysql:5.7-debian', 'gcr.io/ml-pipeline/google/pipelines-test/mysql:$TAG_NAME']
args: ['tag', 'gcr.io/ml-pipeline/mysql:8.0.26', 'gcr.io/ml-pipeline/google/pipelines-test/mysql:$TAG_NAME']
id: 'tagMySqlForMarketplaceTest'
waitFor: ['pullMysql']
- id: 'tagMySqlForMarketplaceMajorMinor'
Expand All @@ -449,8 +449,8 @@ steps:
args:
- -ceux
- |
docker tag gcr.io/ml-pipeline/mysql:5.7-debian gcr.io/ml-pipeline/google/pipelines/mysql:$(cat /workspace/mm.ver)
docker tag gcr.io/ml-pipeline/mysql:5.7-debian gcr.io/ml-pipeline/google/pipelines-test/mysql:$(cat /workspace/mm.ver)
docker tag gcr.io/ml-pipeline/mysql:8.0.26 gcr.io/ml-pipeline/google/pipelines/mysql:$(cat /workspace/mm.ver)
docker tag gcr.io/ml-pipeline/mysql:8.0.26 gcr.io/ml-pipeline/google/pipelines-test/mysql:$(cat /workspace/mm.ver)
docker push gcr.io/ml-pipeline/google/pipelines/mysql:$(cat /workspace/mm.ver)
docker push gcr.io/ml-pipeline/google/pipelines-test/mysql:$(cat /workspace/mm.ver)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,9 +166,20 @@ spec:
args:
# https://dev.mysql.com/doc/refman/5.7/en/server-options.html#option_mysqld_ignore-db-dir
# Ext4, Btrfs etc. volumes root directories have a lost+found directory that should not be treated as a database.
- --ignore-db-dir=lost+found
# ignore-db-dir option has been deprecated in mysql v5.7.16.
#
# In order to upgrade MySQL to v8.0 remove /var/lib/mysql/lost+found folder in mysql-pv-claim
# (mysql-persistent-storage):
#
# kubectl exec -it <mysql-pod-name> -n kubeflow -- bash
# rm -rf /var/lib/mysql/lost+found
gkcalat marked this conversation as resolved.
Show resolved Hide resolved
#
# More details on upgrading MySQL can be found here:
# https://dev.mysql.com/doc/refman/8.0/en/upgrade-prerequisites.html
# https://dev.mysql.com/doc/refman/8.0/en/upgrade-docker-mysql.html
- --datadir
- /var/lib/mysql
- --default-authentication-plugin=mysql_native_password
env:
- name: MYSQL_ALLOW_EMPTY_PASSWORD
value: "true"
Expand Down
15 changes: 13 additions & 2 deletions manifests/gcp_marketplace/test/snapshot-base.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2335,9 +2335,20 @@ spec:
args:
# https://dev.mysql.com/doc/refman/5.7/en/server-options.html#option_mysqld_ignore-db-dir
# Ext4, Btrfs etc. volumes root directories have a lost+found directory that should not be treated as a database.
- --ignore-db-dir=lost+found
# ignore-db-dir option has been deprecated in mysql v5.7.16.
#
# In order to upgrade MySQL to v8.0 remove /var/lib/mysql/lost+found folder in mysql-pv-claim
# (mysql-persistent-storage):
#
# kubectl exec -it <mysql-pod-name> -n kubeflow -- bash
# rm -rf /var/lib/mysql/lost+found
#
# More details on upgrading MySQL can be found here:
# https://dev.mysql.com/doc/refman/8.0/en/upgrade-prerequisites.html
# https://dev.mysql.com/doc/refman/8.0/en/upgrade-docker-mysql.html
- --datadir
- /var/lib/mysql
- --default-authentication-plugin=mysql_native_password
env:
- name: MYSQL_ALLOW_EMPTY_PASSWORD
value: "true"
Expand Down Expand Up @@ -2692,7 +2703,7 @@ metadata:
spec:
descriptor:
type: Kubeflow Pipelines
version: 2.0.0-alpha.3
version: 2.0.0-alpha.5
description: |-
Reusable end-to-end ML workflow
maintainers:
Expand Down
15 changes: 13 additions & 2 deletions manifests/gcp_marketplace/test/snapshot-emissary.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2335,9 +2335,20 @@ spec:
args:
# https://dev.mysql.com/doc/refman/5.7/en/server-options.html#option_mysqld_ignore-db-dir
# Ext4, Btrfs etc. volumes root directories have a lost+found directory that should not be treated as a database.
- --ignore-db-dir=lost+found
# ignore-db-dir option has been deprecated in mysql v5.7.16.
#
# In order to upgrade MySQL to v8.0 remove /var/lib/mysql/lost+found folder in mysql-pv-claim
# (mysql-persistent-storage):
#
# kubectl exec -it <mysql-pod-name> -n kubeflow -- bash
# rm -rf /var/lib/mysql/lost+found
#
# More details on upgrading MySQL can be found here:
# https://dev.mysql.com/doc/refman/8.0/en/upgrade-prerequisites.html
# https://dev.mysql.com/doc/refman/8.0/en/upgrade-docker-mysql.html
- --datadir
- /var/lib/mysql
- --default-authentication-plugin=mysql_native_password
env:
- name: MYSQL_ALLOW_EMPTY_PASSWORD
value: "true"
Expand Down Expand Up @@ -2692,7 +2703,7 @@ metadata:
spec:
descriptor:
type: Kubeflow Pipelines
version: 2.0.0-alpha.3
version: 2.0.0-alpha.5
description: |-
Reusable end-to-end ML workflow
maintainers:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2764,7 +2764,7 @@ metadata:
spec:
descriptor:
type: Kubeflow Pipelines
version: 2.0.0-alpha.3
version: 2.0.0-alpha.5
description: |-
Reusable end-to-end ML workflow
maintainers:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2764,7 +2764,7 @@ metadata:
spec:
descriptor:
type: Kubeflow Pipelines
version: 2.0.0-alpha.3
version: 2.0.0-alpha.5
description: |-
Reusable end-to-end ML workflow
maintainers:
Expand Down
15 changes: 13 additions & 2 deletions manifests/kustomize/third-party/mysql/base/mysql-deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,14 +19,25 @@ spec:
containers:
# https://dev.mysql.com/doc/refman/5.7/en/server-options.html#option_mysqld_ignore-db-dir
# Ext4, Btrfs etc. volumes root directories have a lost+found directory that should not be treated as a database.
# ignore-db-dir option has been deprecated in mysql v5.7.16.
#
# In order to upgrade MySQL to v8.0 remove /var/lib/mysql/lost+found folder in mysql-pv-claim
# (mysql-persistent-storage):
#
# kubectl exec -it <mysql-pod-name> -n kubeflow -- bash
# rm -rf /var/lib/mysql/lost+found
#
# More details on upgrading MySQL can be found here:
# https://dev.mysql.com/doc/refman/8.0/en/upgrade-prerequisites.html
# https://dev.mysql.com/doc/refman/8.0/en/upgrade-docker-mysql.html
- args:
- --ignore-db-dir=lost+found
- --datadir
- /var/lib/mysql
- --default-authentication-plugin=mysql_native_password
env:
- name: MYSQL_ALLOW_EMPTY_PASSWORD
value: "true"
image: gcr.io/ml-pipeline/mysql:5.7-debian
image: gcr.io/ml-pipeline/mysql:8.0.26
name: mysql
ports:
- containerPort: 3306
Expand Down
4 changes: 2 additions & 2 deletions test/tag_for_hosted.sh
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,8 @@ docker tag gcr.io/ml-pipeline/minio:RELEASE.2019-08-14T20-37-41Z-license-complia
docker push gcr.io/$PROJECT_ID/hosted/$COMMIT_SHA/minio:$SEM_VER
docker push gcr.io/$PROJECT_ID/hosted/$COMMIT_SHA/minio:$MM_VER

docker tag gcr.io/ml-pipeline/mysql:5.7-debian gcr.io/$PROJECT_ID/hosted/$COMMIT_SHA/mysql:$SEM_VER
docker tag gcr.io/ml-pipeline/mysql:5.7-debian gcr.io/$PROJECT_ID/hosted/$COMMIT_SHA/mysql:$MM_VER
docker tag gcr.io/ml-pipeline/mysql:8.0.26 gcr.io/$PROJECT_ID/hosted/$COMMIT_SHA/mysql:$SEM_VER
docker tag gcr.io/ml-pipeline/mysql:8.0.26 gcr.io/$PROJECT_ID/hosted/$COMMIT_SHA/mysql:$MM_VER
docker push gcr.io/$PROJECT_ID/hosted/$COMMIT_SHA/mysql:$SEM_VER
docker push gcr.io/$PROJECT_ID/hosted/$COMMIT_SHA/mysql:$MM_VER

Expand Down