Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(backend): Upgrade mysql to 8.0.26 #8351

Merged
merged 6 commits into from
Oct 14, 2022
Merged

fix(backend): Upgrade mysql to 8.0.26 #8351

merged 6 commits into from
Oct 14, 2022

Conversation

gkcalat
Copy link
Member

@gkcalat gkcalat commented Oct 12, 2022

Description of your changes:
Upgrading MySQL to 8.0-debian. Reasons:

  • Current MySQL 5.7 has several critical vulnerabilities:
  • KFP already offers support for MySQL 8.0 via managed storage options (e.g. on GCP). This has been already tested.
  • Other Kubeflow components already support MySQL 8.0 (e.g. katib).
  • MySQL 8.0 is a default version for many platforms (e.g. GCP)

This issue is related to GoogleCloudPlatform/kubeflow-distribution/issues/391.

Checklist:

@zijianjoy
Copy link
Collaborator

Looks like MLMD is not able to connect to DB. I am wondering if we need to update https://github.com/kubeflow/pipelines/blob/master/manifests/kustomize/base/metadata/overlays/db/metadata-db-deployment.yaml#L24 as well.

@zijianjoy
Copy link
Collaborator

Looking closer: It seems that we need to set MLMD DB connection properly in

pipelines/test/manifests/dev/kustomization.yaml

Lines 13 to 16 in 0a9cf22

configMapGenerator:
- behavior: merge
env: params.env
name: pipeline-install-config
.

Log: https://pantheon.corp.google.com/logs/query;query=resource.type%3D%22k8s_container%22%0Aresource.labels.project_id%3D%22ml-pipeline-test%22%0Aresource.labels.location%3D%22us-east1-b%22%0Aresource.labels.cluster_name%3D%22e2e-bd7142d-20387%22%0Aresource.labels.namespace_name%3D%22kubeflow%22%0Aresource.labels.pod_name%3D%22metadata-grpc-deployment-f8d68f687-wzkhq%22;timeRange=2022-10-11T22:10:03.296Z%2F2022-10-12T05:10:03.296152Z;cursorTimestamp=2022-10-12T01:29:47.678869250Z?project=ml-pipeline-test&jsmode=O&mods=prod_coliseum

@google-oss-prow google-oss-prow bot added size/M and removed size/S labels Oct 13, 2022
@gkcalat
Copy link
Member Author

gkcalat commented Oct 13, 2022

/retest

@gkcalat gkcalat changed the title fix(backend): Upgrade mysql to 8.0-debian fix(backend): Upgrade mysql to 8.0.26 Oct 13, 2022
@gkcalat
Copy link
Member Author

gkcalat commented Oct 13, 2022

/assign @chensun

@google-oss-prow google-oss-prow bot added size/L and removed size/M labels Oct 14, 2022
@chensun
Copy link
Member

chensun commented Oct 14, 2022

/test kubeflow-pipeline-e2e-test

@chensun
Copy link
Member

chensun commented Oct 14, 2022

/unhold

@gkcalat
Copy link
Member Author

gkcalat commented Oct 14, 2022

/retest

@chensun
Copy link
Member

chensun commented Oct 14, 2022

/lgtm
/approve

Thanks @gkcalat !

@google-oss-prow google-oss-prow bot added the lgtm label Oct 14, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chensun
Copy link
Member

chensun commented Oct 14, 2022

/test kubeflow-pipeline-mkp-test

@google-oss-prow google-oss-prow bot merged commit 65ee01a into kubeflow:master Oct 14, 2022
jlyaoyuli pushed a commit to jlyaoyuli/pipelines that referenced this pull request Jan 5, 2023
@gkcalat @jlyaoyuli
fix(backend): Upgrade mysql to 8.0.26 (kubeflow#8351)
65c0bd2 
* Upgrade mysql to 8.0-debian

* Downgrade to mysql-8.0.26 to fix mlmd authentication issue

* Fix cloudbuilds

* Fix gcp marketplace manifests

* Cleaning up mysql password from yaml

* Improve comments
@thesuperzapper thesuperzapper mentioned this pull request Feb 21, 2023
Closed
1 task
This was referenced Jun 1, 2023
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chensun chensun chensun left review comments

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@chensun chensun

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gkcalat @zijianjoy @chensun