Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(sdk): Bump KFP Python SDK to support Python v3.10 #8186

Merged
merged 4 commits into from
Aug 24, 2022
Merged

chore(sdk): Bump KFP Python SDK to support Python v3.10 #8186

merged 4 commits into from
Aug 24, 2022

Conversation

alexlatchford
Copy link
Contributor

@alexlatchford alexlatchford commented Aug 23, 2022 •
edited
Loading

Description of your changes:

Expands on this PR to incorporate support for Python v3.10.

I've updated the oss-test-infra repo to include python310 tests (see here), unclear to me how to test this out though 😅

@google-oss-prow
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@alexlatchford
Copy link
Contributor Author

/test

@google-oss-prow
Copy link

@alexlatchford: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test kubeflow-pipeline-backend-test
  • /test kubeflow-pipeline-e2e-test
  • /test kubeflow-pipeline-frontend-test
  • /test kubeflow-pipeline-mkp-snapshot-test
  • /test kubeflow-pipeline-mkp-test
  • /test kubeflow-pipeline-upgrade-test
  • /test kubeflow-pipelines-backend-visualization
  • /test kubeflow-pipelines-component-yaml
  • /test kubeflow-pipelines-components-gcp-python37
  • /test kubeflow-pipelines-components-google-cloud-python38
  • /test kubeflow-pipelines-integration-v2
  • /test kubeflow-pipelines-manifests
  • /test kubeflow-pipelines-samples-v2
  • /test kubeflow-pipelines-sdk-docformatter
  • /test kubeflow-pipelines-sdk-isort
  • /test kubeflow-pipelines-sdk-python37
  • /test kubeflow-pipelines-sdk-python38
  • /test kubeflow-pipelines-sdk-python39
  • /test kubeflow-pipelines-sdk-yapf
  • /test kubeflow-pipelines-tfx-python37

Use /test all to run the following jobs that were automatically triggered:

  • kubeflow-pipelines-samples-v2
  • kubeflow-pipelines-sdk-docformatter
  • kubeflow-pipelines-sdk-isort
  • kubeflow-pipelines-sdk-python37
  • kubeflow-pipelines-sdk-python38
  • kubeflow-pipelines-sdk-python39
  • kubeflow-pipelines-sdk-yapf
  • kubeflow-pipelines-tfx-python37

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Aug 23, 2022
Merged
Merged
connor-mccarthy
connor-mccarthy requested changes Aug 23, 2022
View reviewed changes
Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you separate out the kubernetes version changes 477a23c?

I can't be certain that this is something we'll do (don't want to waste your time), but it is definitely worth considering. I will do some testing and discuss with the team.

Also, added some local testing comments and feedback to the oss-test-infra PR GoogleCloudPlatform/oss-test-infra#1732 (comment). I tested locally and all tests passed.

cc @chensun

@google-oss-prow google-oss-prow bot added size/XS and removed size/M labels Aug 23, 2022
@alexlatchford
Copy link
Contributor Author

Can you separate out the kubernetes version changes 477a23c?

I can't be certain that this is something we'll do (don't want to waste your time), but it is definitely worth considering. I will do some testing and discuss with the team.

Also, added some local testing comments and feedback to the oss-test-infra PR GoogleCloudPlatform/oss-test-infra#1732 (comment). I tested locally and all tests passed.

cc @chensun

Sounds good, just removed them. I do have them in a separate PR here so happy to do them separately, I was just being lazy before 😅

@alexlatchford alexlatchford requested review from connor-mccarthy and removed request for chensun August 23, 2022 16:48
@alexlatchford alexlatchford marked this pull request as ready for review August 24, 2022 19:44
@google-oss-prow google-oss-prow bot requested a review from chensun August 24, 2022 19:45
@alexlatchford
Copy link
Contributor Author

/test kubeflow-pipelines-sdk-python310

connor-mccarthy
connor-mccarthy requested changes Aug 24, 2022
View reviewed changes
Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like kubeflow-pipelines-sdk-python310 is passing. Great!

Can you add a release note to ./sdk/RELEASE.md indicating that we now support 3.10?

@alexlatchford
Copy link
Contributor Author

Looks like kubeflow-pipelines-sdk-python310 is passing. Great!

Can you add a release note to ./sdk/RELEASE.md indicating that we now support 3.10?

Sweet, will do!

@alexlatchford alexlatchford requested review from connor-mccarthy and removed request for chensun August 24, 2022 20:07
connor-mccarthy
connor-mccarthy approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks for this, @alexlatchford! Since tests appear to be passing, can you submit another PR stripping the optional: true and skip_report: true from GoogleCloudPlatform/oss-test-infra#1732? Thanks for working through the multistep test infra changes with me :)

@google-oss-prow google-oss-prow bot added the lgtm label Aug 24, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: connor-mccarthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@alexlatchford
Copy link
Contributor Author

/lgtm /approve

Thanks for this, @alexlatchford! Since tests appear to be passing, can you submit another PR stripping the optional: true and skip_report: true from GoogleCloudPlatform/oss-test-infra#1732? Thanks for working through the multistep test infra changes with me :)

Sure done :) GoogleCloudPlatform/oss-test-infra#1734

@connor-mccarthy
Copy link
Member

/retest

@google-oss-prow google-oss-prow bot merged commit 459e535 into kubeflow:master Aug 24, 2022
jlyaoyuli pushed a commit to jlyaoyuli/pipelines that referenced this pull request Jan 5, 2023
@alexlatchford @jlyaoyuli
chore(sdk): Bump KFP Python SDK to support Python v3.10 (kubeflow#8186)
430fb26 
* Update upper bound for kubernetes dependency

* Bump KFP Python SDK to support Py v3.10

* Reset requirements.* changes to isolate out Python v3.10 changes

* Add in release note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connor-mccarthy connor-mccarthy connor-mccarthy approved these changes

Assignees

@connor-mccarthy connor-mccarthy

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexlatchford @connor-mccarthy