Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in presubmit tests for kubeflow/pipelines for python v3.10 #1732

Merged

Conversation

alexlatchford
Copy link
Contributor

Trying to align with this PR

@google-oss-prow
Copy link
Contributor

Hi @alexlatchford. Thanks for your PR.

I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good way to add in new test incrementally is by using optional: true and skip_report: true. This allows us to run the tests, without them gating merge. Then we can remove those fields later. See 22758a8 for an example then 40ca53a for the removal. (ref)

You can also test locally using ./pj-on-kind.sh (ref). Then inspect the pod logs.

./prow/pj-on-kind.sh kubeflow-pipelines-sdk-python310

…esubmit tests for kubeflow/pipelines for Python v3.10
@alexlatchford alexlatchford requested review from connor-mccarthy and removed request for chensun and zijianjoy August 23, 2022 16:33
@connor-mccarthy
Copy link
Member

I verified that this test suite executes successfully.

/lgtm

/cc @chensun
for approval

@google-oss-prow google-oss-prow bot requested a review from chensun August 24, 2022 16:21
@google-oss-prow google-oss-prow bot added the lgtm label Aug 24, 2022
@alexlatchford
Copy link
Contributor Author

Sweet thanks @connor-mccarthy!

Copy link
Member

@chensun chensun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Thanks!

@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexlatchford, chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit cd6e6b4 into GoogleCloudPlatform:master Aug 24, 2022
@google-oss-prow
Copy link
Contributor

@alexlatchford: Updated the job-config configmap in namespace default at cluster default using the following files:

  • key kubeflow-pipelines-presubmits.yaml using file prow/prowjobs/kubeflow/pipelines/kubeflow-pipelines-presubmits.yaml

In response to this:

Trying to align with this PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants