-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add in presubmit tests for kubeflow/pipelines for python v3.10 #1732
Add in presubmit tests for kubeflow/pipelines for python v3.10 #1732
Conversation
Hi @alexlatchford. Thanks for your PR. I'm waiting for a GoogleCloudPlatform member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good way to add in new test incrementally is by using optional: true
and skip_report: true
. This allows us to run the tests, without them gating merge. Then we can remove those fields later. See 22758a8 for an example then 40ca53a for the removal. (ref)
You can also test locally using ./pj-on-kind.sh
(ref). Then inspect the pod logs.
./prow/pj-on-kind.sh kubeflow-pipelines-sdk-python310
…esubmit tests for kubeflow/pipelines for Python v3.10
I verified that this test suite executes successfully. /lgtm /cc @chensun |
Sweet thanks @connor-mccarthy! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thanks!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexlatchford, chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@alexlatchford: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Trying to align with this PR