Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): no longer require KFP client for kfp components build #7430

Merged
merged 2 commits into from Mar 17, 2022
Merged

fix(sdk): no longer require KFP client for kfp components build #7430

merged 2 commits into from Mar 17, 2022

Conversation

ghost
Copy link

@ghost ghost commented Mar 16, 2022

Description of your changes:

Fixed issue where kfp components build command required a connection to a KFP API server

Checklist:

@google-oss-prow
Copy link

Hi @browningjp-datatonic. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ghost
Copy link
Author

ghost commented Mar 16, 2022

@chensun this is #7410 reapplied on master

@chensun
Copy link
Member

chensun commented Mar 17, 2022

/ok-to-test

@chensun
Copy link
Member

chensun commented Mar 17, 2022

/lgtm
/approve

Thanks!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 02a52a4 into kubeflow:master Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant