Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): no longer require KFP client for kfp components build #7410

Merged
merged 2 commits into from Mar 16, 2022
Merged

fix(sdk): no longer require KFP client for kfp components build #7410

merged 2 commits into from Mar 16, 2022

Conversation

ghost
Copy link

@ghost ghost commented Mar 13, 2022

Fixed issue where kfp components build command required a connection to a KFP API server

Checklist:

@google-oss-prow
Copy link

Hi @browningjp-datatonic. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chensun
Copy link
Member

chensun commented Mar 14, 2022

/ok-to-test

1 similar comment
@chensun
Copy link
Member

chensun commented Mar 14, 2022

/ok-to-test

@chensun
Copy link
Member

chensun commented Mar 14, 2022

Thank you @browningjp-datatonic for the fix!
Can you please add an entry in the SDK release note for this change?https://github.com/kubeflow/pipelines/blob/master/sdk/RELEASE.md#bug-fixes-and-other-changes

@ghost
Copy link
Author

ghost commented Mar 15, 2022

@chensun done on this PR - presume you meant in this branch rather than the master branch?

@chensun
Copy link
Member

chensun commented Mar 16, 2022

@chensun done on this PR - presume you meant in this branch rather than the master branch?

Sorry, I didn't realize this PR is targeting sdk/release-1.8 branch. What you have now is fine.

We would still like to have this fix in master branch as well. The code you're touching is currently in deprecated folder in the master branch, but we plan to gradually revive the code that is still relevant, and I think the cli folder would be one of them.
If you don't mind the trouble, can you please re-apply this change to master branch as well? Or we can do it later as well.
Thanks again for the fix!

/lgtm
/approve

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chensun
Copy link
Member

chensun commented Mar 16, 2022

/test kubeflow-pipelines-samples-v2

@google-oss-prow
Copy link

@browningjp-datatonic: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-samples-v2 99f3786 link true /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chensun chensun merged commit d5c6c5b into kubeflow:sdk/release-1.8 Mar 16, 2022
@ghost
Copy link
Author

ghost commented Mar 16, 2022

@chensun no problem, I will do the same on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant