Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk)!: move v2 to main namespace #7376

Merged
merged 2 commits into from
Mar 4, 2022

Conversation

ji-yaqi
Copy link
Contributor

@ji-yaqi ji-yaqi commented Mar 4, 2022

Description of your changes:

Checklist:

@ji-yaqi ji-yaqi requested a review from chensun March 4, 2022 17:59
@connor-mccarthy
Copy link
Member

/retest

Copy link
Member

@connor-mccarthy connor-mccarthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Yaqi, I have a few questions after my first pass:

  1. I noticed a few outstanding v2 SDK references that may or may not be an issue (I'm unsure). Can you let me know what you think?
  1. Can you explain why we want to keep the v2/ directory with only an empty __init__.py file? Is it possible to remove this? Tests pass when this is removed.

@ji-yaqi
Copy link
Contributor Author

ji-yaqi commented Mar 4, 2022

Hi Yaqi, I have a few questions after my first pass:

  1. I noticed a few outstanding v2 SDK references that may or may not be an issue (I'm unsure). Can you let me know what you think?
  1. Can you explain why we want to keep the v2/ directory with only an empty __init__.py file? Is it possible to remove this? Tests pass when this is removed.

Thanks for the review!

  1. Edited the first one, for dockerignore, it refers to the backend folders.
  2. For empty init, we will provide possible redirects in next PR, for current users to migrate. Thanks for pointing it out! @connor-mccarthy

@connor-mccarthy
Copy link
Member

/approve

@chensun
Copy link
Member

chensun commented Mar 4, 2022

/lgtm
/approve

Thanks!

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun, connor-mccarthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 8bb0d0e into kubeflow:master Mar 4, 2022
@ji-yaqi ji-yaqi deleted the merge_v2 branch March 4, 2022 22:03
abaland pushed a commit to abaland/pipelines that referenced this pull request May 29, 2022
* feat(sdk)!: move v2 to main namespace

* edit samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants