Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk)!: drop support for python 3.6 #7303

Merged
merged 4 commits into from
Feb 15, 2022
Merged

feat(sdk)!: drop support for python 3.6 #7303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6637da9
chore(sdk): drop support for python 3.6
ji-yaqi Feb 14, 2022
bba7a99
empty
ji-yaqi Feb 14, 2022
c1e8080
address comments
ji-yaqi Feb 15, 2022
b008ba3
Merge branch 'master' into py3.6
ji-yaqi Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ Note, when releasing from master, all the below mentions of "release branch" mea
It will prompt you whether to push it to release branch. Press `y` and hit `Enter`.

Note, the script will clone kubeflow/pipelines repo into a temporary location on your computer, make those changes and attempt to push to upstream, so that it won't interfere with your current git repo.

If you see error "docker.sock: connect: permission error", you need to [allow managing docker as a non-root user](https://docs.docker.com/engine/install/linux-postinstall/#manage-docker-as-a-non-root-user).

1. View related cloudbuild jobs' statuses by clicking the latest commit's status icon
Expand Down Expand Up @@ -263,7 +263,7 @@ fill in the description. Detailed steps:
<pre>
To deploy Kubeflow Pipelines in an existing cluster, follow the instruction in [here](https://www.kubeflow.org/docs/pipelines/standalone-deployment-gcp/) or via UI [here](https://console.cloud.google.com/ai-platform/pipelines)

Install python SDK (python 3.6 above) by running:
Install python SDK (python 3.7 above) by running:

```bash
python3 -m pip install kfp kfp-server-api --upgrade
Expand Down Expand Up @@ -309,7 +309,7 @@ Update master branch to the same version and include latest changelog:
git commit -m "chore(release): bump version to $VERSION on master branch"
```

1. If current release is not a prerelease, create a PR to update version in kubeflow documentation website:
1. If current release is not a prerelease, create a PR to update version in kubeflow documentation website:
<https://github.com/kubeflow/website/blob/master/layouts/shortcodes/pipelines/latest-version.html>

Note, there **MUST NOT** be a line ending in the file. Editing on GitHub always add a line ending
Expand All @@ -322,7 +322,7 @@ Update master branch to the same version and include latest changelog:

and create a PR to update the version, e.g. <https://github.com/kubeflow/website/pull/1942>.

1. Follow [Upgrade KFP](https://github.com/kubeflow/testing/tree/master/test-infra/kfp) instruction to upgrade KFP manifests in test-infra.
1. Follow [Upgrade KFP](https://github.com/kubeflow/testing/tree/master/test-infra/kfp) instruction to upgrade KFP manifests in test-infra.

## Release Process Development

Expand Down
1 change: 1 addition & 0 deletions sdk/RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
* Remove sdk/python/kfp/v2/google directory for v2, including google client and custom job [\#6886](https://github.com/kubeflow/pipelines/pull/6886)
* APIs imported from the v1 namespace are no longer supported by the v2 compiler. [\#6890](https://github.com/kubeflow/pipelines/pull/6890)
* Deprecate v2 compatible mode in v1 compiler. [\#6958](https://github.com/kubeflow/pipelines/pull/6958)
* Drop support for python 3.6 [\#7303](https://github.com/kubeflow/pipelines/pull/7303)

### For Pipeline Authors

Expand Down
3 changes: 1 addition & 2 deletions sdk/python/requirements.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,4 @@ absl-py>=0.9,<=0.11
kfp-pipeline-spec>=0.1.13,<0.2.0
fire>=0.3.1,<1
pydantic>=1.8.2,<2
dataclasses>=0.8,<1; python_version<"3.7"
typing-extensions>=3.7.4,<5; python_version<"3.9"
typing-extensions>=3.7.4,<4; python_version<"3.9"
6 changes: 2 additions & 4 deletions sdk/python/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,7 @@
'pydantic>=1.8.2,<2',
'typer>=0.3.2,<1.0',
# Standard library backports
'dataclasses;python_version<"3.7"',
'typing-extensions>=3.7.4,<5;python_version<"3.9"',
'typing-extensions>=3.7.4,<4;python_version<"3.9"',
]

EXTRAS_REQUIRE = {
Expand Down Expand Up @@ -121,7 +120,6 @@ def find_version(*file_path_parts):
'Intended Audience :: Science/Research',
'License :: OSI Approved :: Apache Software License',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.6',
'Programming Language :: Python :: 3.7',
'Programming Language :: Python :: 3.8',
'Programming Language :: Python :: 3.9',
Expand All @@ -131,7 +129,7 @@ def find_version(*file_path_parts):
'Topic :: Software Development :: Libraries',
'Topic :: Software Development :: Libraries :: Python Modules',
],
python_requires='>=3.6.1',
python_requires='>=3.7.0',
include_package_data=True,
entry_points={
'console_scripts': [
Expand Down