Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk)!: drop support for python 3.6 #7303

Merged
merged 4 commits into from
Feb 15, 2022
Merged

feat(sdk)!: drop support for python 3.6 #7303

merged 4 commits into from
Feb 15, 2022

Conversation

ji-yaqi
Copy link
Contributor

@ji-yaqi ji-yaqi commented Feb 14, 2022 •
edited
Loading

chensun
chensun reviewed Feb 14, 2022
View reviewed changes
sdk/python/requirements.in Outdated Show resolved Hide resolved
@ji-yaqi
Copy link
Contributor Author

ji-yaqi commented Feb 14, 2022

/retest

@ji-yaqi ji-yaqi mentioned this pull request Feb 14, 2022
Closed
1 task
@ji-yaqi
Copy link
Contributor Author

ji-yaqi commented Feb 14, 2022

/retest

@chensun chensun changed the title chore(sdk): drop support for python 3.6 feat(sdk)!: drop support for python 3.6 Feb 14, 2022
@chensun
Copy link
Member

chensun commented Feb 15, 2022

/lgtm
/approve

Thanks!

@google-oss-prow google-oss-prow bot added the lgtm label Feb 15, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chensun
Copy link
Member

chensun commented Feb 15, 2022

/test kubeflow-pipelines-samples-v2

@google-oss-prow google-oss-prow bot removed the lgtm label Feb 15, 2022
@chensun
Copy link
Member

chensun commented Feb 15, 2022

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 15, 2022
@google-oss-prow
Copy link

@ji-yaqi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-sdk-python36 6637da9 link true /test kubeflow-pipelines-sdk-python36
kubeflow-pipelines-samples-v2 b008ba3 link unknown /test kubeflow-pipelines-samples-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@chensun
Copy link
Member

chensun commented Feb 15, 2022

@ji-yaqi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kubeflow-pipelines-sdk-python36 6637da9 link true /test kubeflow-pipelines-sdk-python36
kubeflow-pipelines-samples-v2 b008ba3 link unknown /test kubeflow-pipelines-samples-v2

Some of the sample tests failed due to OOMKilled, likely caused by too many concurrent test runs at the same time.
The tests was passing this morning before the other PRs were merged: https://oss-prow.knative.dev/view/gs/oss-prow/pr-logs/pull/kubeflow_pipelines/7303/kubeflow-pipelines-samples-v2/1493637564358201344
And I don't see this PR has potential compatibility issue with the recently merged PRs. So going to skip the sample test and merge it as-is.

@chensun chensun merged commit 54d5789 into kubeflow:master Feb 15, 2022
@connor-mccarthy connor-mccarthy mentioned this pull request Mar 18, 2022
Merged
1 task
@mai-nakagawa mai-nakagawa mentioned this pull request Apr 28, 2022
Merged
abaland pushed a commit to abaland/pipelines that referenced this pull request May 29, 2022
@ji-yaqi @abaland
feat(sdk)!: drop support for python 3.6 (kubeflow#7303)
c40b567 
* chore(sdk): drop support for python 3.6

* empty

* address comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chensun chensun chensun left review comments

@zijianjoy zijianjoy Awaiting requested review from zijianjoy

Assignees

@chensun chensun

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SDK: Drop support for Python 3.6
2 participants
@ji-yaqi @chensun