fixes Change the application component to agree with kubernetes-sigs application CRD

[kkasravi]

fixes #1856, #1831

• Each child will have annotations and labels applied that is reference in the Application.Spec.Components

    {
          annotations+: {
            "kubernetes.io/application": params.name,
          },
          labels+: {
            "app.kubernetes.io/name": params.name,
            "app.kubernetes.io/component": resource.metadata.name,
            app: params.name,
            component: resource.metadata.name,
    }

• Reparenting of the children will be made to point to the controller
• Deletion of child components will occur if the application is deleted

---

This change is 

[kkasravi]

@jlewi

This PR is failing at

INFO|2019-01-10T03:12:03|test_jsonnet_formatting.py:51| Running test_jsonnet_formatting
usage: test_jsonnet_formatting.py [-h] [--src_dir SRC_DIR]
                                 [--exclude_dirs EXCLUDE_DIRS]
test_jsonnet_formatting.py: error: unrecognized arguments: --project=kubeflow-ci --artifacts_dir=/mnt/test-data-volume/kubeflow-presubmit-unittests-2154-30d1608-4
974-d87b/output/artifacts
INFO|2019-01-10T03:12:03|test_helper.py:62| Writing file: /mnt/test-data-volume/kubeflow-presubmit-unittests-2154-30d1608-4974-d87b/output/artifacts/junit_test-js
onnet-formatting.xml

Is there a mismatch between kubeflow/testing and kubeflow/kubeflow?

[jlewi]

I think you need to remove the flag --artifacts_dir

kubeflow/testing/workflows/components/unit_tests.jsonnet

Line 137 in bce8f4b

"--artifacts_dir=" + artifactsDir,

We recently changed test_jsonnet_formatting to raise an error on unknown args rather than just ignoring them.

We always checkout HEAD of extra repos like kubeflow/testing so these types of breaks can occur

kubeflow/testing/workflows/components/unit_tests.jsonnet

Line 94 in bce8f4b

value: "kubeflow/tf-operator@HEAD;kubeflow/testing@HEAD",

Pinning extra repos to specific versions is one way to prevent those types of breaks.

[kkasravi]

/retest

[kkasravi]

@jlewi - think this is fairly close to what you had in mind. Separate issue of application CRs and dependencies opened #2257

[jlewi]

Much nicer thanks!

[jlewi]

/lgtm
/approve

I think you just need to fix the test.

[kkasravi]

/retest

[kkasravi]

@jlewi katib is catching a sync failure in Metacontroller which occasionally happens when the object has been modified during sync processing. Error is harmless.... i should be able to resolve by tomorrow

[kkasravi]

@jlewi - passing now. What I've observed though in the e2e tests is #980 that is happening in the application-controller.
I've made a few changes which minimizes when this happens by adding resourceVersion to each child I return in the sync hook. Safe to merge.

[jlewi]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi, kkasravi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jlewi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment