-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a kubeflow application in the GCP Marketplace #1691
Comments
/assign @jlewi |
We had a lengthy discussion about putting Kubeflow in the apps marketplace and we decided against it at least for now. The primary reason is that apps marketplace doesn't give us enough control so the resulting experience would not be the recommended Kubeflow experience (i.e. what users get if they follow our GKE getting started guide). This is why we went down the path of building a click to deploy web app. GKE marketplace really only lets you create K8s resources. Its primarily a wrapper around YAML manifests or helm packages. At this time it offers very little control over the GKE cluster itself (right now we use deployment manager to specify a lot of GKE configuration options). If you need cluster admin permissions, I think marketplace needs to prompt users in Cloud shell for permissions. (I think marketplace prefers for everything to be namespace scoped). More importantly it doesn't let us do things like create IAM roles, service accounts, and most importantly setup IAP. One direction we did discuss was putting our click to deploy app into marketplace. This makes more sense if we turn our deploy app into an admin app for Kubeflow deployments. We could then create custom, complex wizards that would walk admins/users through setting up Kubeflow. For example, this would allow us to create a wizard that would allow an admin to setup Kubeflow to be deployed via GitOps. |
Hi @jlewi We do have a CRD/metacontroller based approach that allows this to work with Application CR's and namespaced users (RoleBindings). Ebi (@ashahba) and I could open a PR in the next week or so - we were thinking of showing you a demo in that timeframe. The approach doesn't exclude GKE/IAP and could possibly integrate within GKE/IAP. Since users are namespace scoped RoleBindings, they might be able to include the IAM subject in addition to the user based serviceaccount. We haven't explored this yet. |
A demo at one of the community meetings would be great. |
This has been implemented in #2154 |
* add ibm custom openshift kfdef add hostpath to list of volumes in istio scc add tekton scc add cached deployer to scc add pipeline runner to scc add tekton variable to kustomize * add generated test files * rename kfdef filename remove pipeline runner anyuid * regenerate tests
GKE allows the user to deploy an Application CRD using the GKE console
as shown below:
The applications in the marketplace include seldon io.
We should add
a kubeflow application using the Application CRD once the PR is merged. The kubeflow Application CR implementation will allow different components to be bundled and could be exposed in the Configuration section in a similar way as the seldonio configuration
Unfortunately I'm not sure how to add this to the marketplace. @jlewi ?
The text was updated successfully, but these errors were encountered: