Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Adding ScrapCodes as approver. #754

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

ScrapCodes
Copy link
Contributor

Some of the recent PRs.

#750 #709 #706 #633 #636 #638 #646

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

@Tomcli
Copy link
Member

Tomcli commented Oct 18, 2021

/lgtm

@Tomcli
Copy link
Member

Tomcli commented Oct 18, 2021

thanks @ScrapCodes for all your contributions

FYI @animeshsingh @ckadner @drewbutlerbb4

@Tomcli Tomcli changed the title Proposal: Adding myself as approver. Proposal: Adding ScrapCodes as approver. Oct 18, 2021
@ScrapCodes
Copy link
Contributor Author

Contribution is part of my duty. Thank you @Tomcli and @animeshsingh for all the guidance.

@Tomcli
Copy link
Member

Tomcli commented Oct 20, 2021

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ScrapCodes, Tomcli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 3f13201 into kubeflow:master Oct 20, 2021
@animeshsingh
Copy link
Collaborator

Congrats @ScrapCodes !!!!!

@ckadner
Copy link
Member

ckadner commented Oct 21, 2021

Well deserved @ScrapCodes! Thanks for your contributions.

@ScrapCodes
Copy link
Contributor Author

Thank you @animeshsingh and @ckadner !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants