feat(sdk): inline user defined custom tasks #636
Conversation
guides/advanced_user_guide.md
Outdated
| - **--taskSpec** (optional): Kubernetes Resource Spec for your custom task CRD. The value needs to define in Python Dictionary. | ||
| - **--taskSpec** (optional): Kubernetes Resource Spec for your custom task CRD. One of `--taskSpec` or `--taskRef` can be specified at a time. | ||
| The value should be a Python Dictionary. | ||
| - **--taskRef** (optional): Kubernetes Resource Spec for your custom task CRD. This gets inlined in the pipeline. One of `--taskSpec` or `--taskRef` can be specified at a time. |
There was a problem hiding this comment.
taskSpec should be the one that inlined in the pipeline. taskRef just generate the spec in a separate CRD.
There was a problem hiding this comment.
Ok, I was thinking, if we swap the taskSpec meaning, the custom controller who do not yet support embedded spec, will stop working.
|
I saw the file changed in PR #633 also exists in this PR, I think the main purpose is the document right? The document change looks good to me. |
|
@ScrapCodes need to rebase this |
|
@Tomcli rebased !! |
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| apiVersion: custom_task_api_version |
There was a problem hiding this comment.
Just quick question, isn't custom_task_ref.py will generate this CRD since we are using taskRef?
There was a problem hiding this comment.
It is generated in tmp/ dir and cleaned up. Our tests do not assert the generated CRDs. Do you think it should be changed?
There was a problem hiding this comment.
I opened an issue on it, but we didn't get time to implement it yet.
#610
ScrapCodes
force-pushed
the
todo2
branch
4 times, most recently
from
9368157
to
1d7e1fd
Compare
sdk/python/tests/compiler/testdata/custom_task_ref_customtask_cr1.yaml
Outdated
Show resolved
Hide resolved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ScrapCodes, Tomcli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Some of the recent PRs. kubeflow#750 kubeflow#709 kubeflow#706 kubeflow#633 kubeflow#636 kubeflow#638 kubeflow#646
Which issue is resolved by this Pull Request:
Resolves #627
Description of your changes:
inline user defined custom tasks
Added tests, docs.
Environment tested:
python --version):tkn version):kubectl version):/etc/os-release):Checklist:
Do you want this pull request (PR) cherry-picked into the current release branch?
Learn more about cherry-picking updates into the release branch.