Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove persistentVolumeClaim by volumeClaimTemplate #309

Merged
merged 2 commits into from
Sep 16, 2020

Conversation

fenglixa
Copy link
Member

Which issue is resolved by this Pull Request:
Resolves #181

Description of your changes:
Remove persistentVolumeClaim by volumeClaimTemplate, since we already used the Tekton version > 0.12
Environment tested:

(.venv)  fengli@fenglis-MacBook-Pro  ~/go/src/github.com/kubeflow/kfp-tekton/sdk/python/tests   remove_pvc  kc get po |grep file
file-passing-pipelines-gen-params-mv8h8-pod-hqhnv         0/1     Completed   0          2d13h
file-passing-pipelines-print-params-25vkf-pod-zvpsm       0/1     Completed   0          2d13h
file-passing-pipelines-print-text-2-qsccx-pod-s5fkx       0/1     Completed   0          2d13h
file-passing-pipelines-print-text-3-xj69j-pod-mxvl8       0/1     Completed   0          2d13h
file-passing-pipelines-print-text-4-kfnr7-pod-9rfxq       0/1     Completed   0          2d13h
file-passing-pipelines-print-text-5-l9snc-pod-jtbhc       0/1     Completed   0          2d13h
file-passing-pipelines-print-text-dclrj-pod-w9lfj         0/1     Completed   0          2d13h
file-passing-pipelines-repeat-line-x45z5-pod-44lbv        0/1     Completed   0          2d13h
file-passing-pipelines-split-text-lines-crb4d-pod-hjdw7   0/2     Completed   0          2d13h
file-passing-pipelines-sum-numbers-fpdvm-pod-kq6r7        0/1     Completed   0          2d13h
file-passing-pipelines-write-numbers-6w9rb-pod-f8tx5      0/1     Completed   0          2d13h
(.venv)  fengli@fenglis-MacBook-Pro  ~/go/src/github.com/kubeflow/kfp-tekton/sdk/python/tests   remove_pvc  tkn pr describe file-passing-pipelines
Name:        file-passing-pipelines
Namespace:   feng-test
Timeout:     1h0m0s
Labels:
 tekton.dev/pipeline=file-passing-pipelines

🌡️  Status

STARTED      DURATION    STATUS
2 days ago   2 minutes   Succeeded

📦 Resources

 No resources

⚓ Params

 No params

🗂  Taskruns

 NAME                                              TASK NAME          STARTED      DURATION     STATUS
 ∙ file-passing-pipelines-print-text-5-l9snc       print-text-5       2 days ago   6 seconds    Succeeded
 ∙ file-passing-pipelines-print-text-3-xj69j       print-text-3       2 days ago   10 seconds   Succeeded
 ∙ file-passing-pipelines-print-text-2-qsccx       print-text-2       2 days ago   1 minute     Succeeded
 ∙ file-passing-pipelines-print-text-4-kfnr7       print-text-4       2 days ago   13 seconds   Succeeded
 ∙ file-passing-pipelines-sum-numbers-fpdvm        sum-numbers        2 days ago   15 seconds   Succeeded
 ∙ file-passing-pipelines-print-text-dclrj         print-text         2 days ago   1 minute     Succeeded
 ∙ file-passing-pipelines-print-params-25vkf       print-params       2 days ago   1 minute     Succeeded
 ∙ file-passing-pipelines-write-numbers-6w9rb      write-numbers      2 days ago   15 seconds   Succeeded
 ∙ file-passing-pipelines-gen-params-mv8h8         gen-params         2 days ago   11 seconds   Succeeded
 ∙ file-passing-pipelines-split-text-lines-crb4d   split-text-lines   2 days ago   22 seconds   Succeeded
 ∙ file-passing-pipelines-repeat-line-x45z5        repeat-line        2 days ago   14 seconds   Succeeded

@kubeflow-bot
Copy link

This change is Reviewable

@fenglixa
Copy link
Member Author

@Tomcli , Thanks for your comments, I addressed it just now. is it OK for you now? Thanks!

@Tomcli Tomcli mentioned this pull request Sep 16, 2020
@Tomcli
Copy link
Member

Tomcli commented Sep 16, 2020

Thanks @fenglixa, we need to document this along with updating the samples you have. But those can be done in a separate PR.
/lgtm

@Tomcli
Copy link
Member

Tomcli commented Sep 16, 2020

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove PVC definition alone. Generate it with pipelinerun together
4 participants