Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PVC definition alone. Generate it with pipelinerun together #181

Closed
2 tasks done
fenglixa opened this issue Jun 11, 2020 · 4 comments · Fixed by #309
Closed
2 tasks done

Remove PVC definition alone. Generate it with pipelinerun together #181

fenglixa opened this issue Jun 11, 2020 · 4 comments · Fixed by #309
Assignees
@fenglixa
Labels
area/jupyter kind/feature

Comments

@fenglixa
Copy link
Member

fenglixa commented Jun 11, 2020 •
edited
Loading

/kind feature

Description:
[A clear and concise description of what your proposal. What problem does it solve?]
Create pvc for pipelinerun if using big data passing. As we used workspaces in tekton pipelines which depends on it.

TODO:
Remove PVC if Tekton version > = 0.12, use 'volumeClaimTemplate' instead

'volumeClaimTemplate' is not support if Tekton version < 0.12

Dependency:

Additional information:
[Miscellaneous information that will assist in solving the issue.]

/assign
@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue.
See dashboard for more details.

1 similar comment
@issue-label-bot
Copy link

Issue Label Bot is not confident enough to auto-label this issue.
See dashboard for more details.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/jupyter 0.69

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@animeshsingh animeshsingh changed the title Remove PVC defination alone. Generate it with pipelinerun together Remove PVC definition alone. Generate it with pipelinerun together Jun 12, 2020
@fenglixa fenglixa mentioned this issue Jun 24, 2020
Merged
@Tomcli Tomcli mentioned this issue Jul 21, 2020
Closed
@Hachimaki Hachimaki mentioned this issue Aug 4, 2020
Closed
@fenglixa
Copy link
Member Author

Start working on this issue now

@fenglixa fenglixa mentioned this issue Sep 13, 2020
Merged
@ckadner ckadner mentioned this issue Nov 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fenglixa fenglixa

Labels
area/jupyter kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove persistentVolumeClaim by volumeClaimTemplate fenglixa/kfp-tekton
2 participants
@fenglixa @k8s-ci-robot