Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk): add pipeline_conf.timeout sdk support #1108

Merged
merged 2 commits into from
Dec 14, 2022

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented Dec 13, 2022

Which issue is resolved by this Pull Request:
Resolves #1100

Description of your changes:
Add pipeline level timeout config via kfp pipeline_conf object.

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

@Tomcli
Copy link
Member Author

Tomcli commented Dec 13, 2022

/assign @yhwang

@yhwang
Copy link
Member

yhwang commented Dec 13, 2022

missing timeout.yaml?

@google-oss-prow google-oss-prow bot added size/L and removed size/XS labels Dec 13, 2022
@Tomcli
Copy link
Member Author

Tomcli commented Dec 13, 2022

missing timeout.yaml?

I updated the test script to also take kfp config object now. The new test case should be generated.

@yhwang
Copy link
Member

yhwang commented Dec 14, 2022

A little confused by the timeout for task vs pipeline. I assume the pipeline conf should map to the pipeline timeout. as for task level timeout, do we want to provide another property to specify the task level timeout?

Copy link
Member

@yhwang yhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Dec 14, 2022
@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli, yhwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit fb32672 into kubeflow:master Dec 14, 2022
Tomcli added a commit that referenced this pull request Jan 9, 2023
* add pipeline_conf.timeout sdk support

* update unit test script to take kfp config object
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PipelineConf provided with timeouts does not generate timeouts block in PipelineRun
2 participants