Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PipelineConf provided with timeouts does not generate timeouts block in PipelineRun #1100

Closed
n-stout opened this issue Dec 8, 2022 · 1 comment · Fixed by #1108
Closed
Labels

Comments

@n-stout
Copy link

n-stout commented Dec 8, 2022

/kind bug

What steps did you take and what happened:
Create a PipelineConf object with set_timeout(NNN) applied
Supply pipeline_conf via kfp_tekton.compiler.TektonCompiler().compile(... ,pipeline_conf=XXX) and note in YAML it does not apply timeouts set from passed configuration

What did you expect to happen:
Timeouts to be honored and a timeouts: section generated in the YAML

Environment:

  • Python Version (use python --version): 3.9.7
  • SDK Version: 1.4.0
  • Tekton Version (use tkn version): n/a
  • Kubernetes Version (use kubectl version): n/a
  • OS (e.g. from /etc/os-release): Debian GNU/Linux 11 (bullseye)
@Tomcli
Copy link
Member

Tomcli commented Dec 13, 2022

in kfp-tekton we are using the dsl.get_pipeline_conf().set_timeout(1) syntax, but since kfp supports the pipeline_conf object as well, I can add a PR to also add that support

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants