Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Skip some logics for terminated job and add PodGroup reconcile loop #93

Merged
merged 2 commits into from
May 17, 2020
Merged

Skip some logics for terminated job and add PodGroup reconcile loop #93

merged 2 commits into from
May 17, 2020

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented May 17, 2020 •
edited
Loading

Resolve #92 #94

  1. Skip checking activeDeadline or backoffLimit if job terminated
  2. Add PodGroup reconcile logic

@Jeffwan
Skip check activeDeadline or backoffLimit if job terminated
339bfcb 
This is originally from kubeflow/training-operator#1111

Signed-off-by: Jiaxin Shan <[email protected]>
@Jeffwan
Add PodGroup reconcile logic
10c838f 
This is missing in kubeflow/common. We need this to make sure minAvailableReplicas is correct in PodGroup for each training job

Signed-off-by: Jiaxin Shan <[email protected]>
@kubeflow-bot
Copy link

This change is Reviewable

@ChanYiLin
Copy link
Member

/LGTM

terrytangyuan
terrytangyuan approved these changes May 17, 2020
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a63fa3d into kubeflow:master May 17, 2020
georgkaleido pushed a commit to georgkaleido/common that referenced this pull request Jun 9, 2022
@depfu
chore(deps): update all Yarn dependencies (2022-01-26) (kubeflow#93)
78d1eee
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

@gaocegege gaocegege Awaiting requested review from gaocegege

@johnugeorge johnugeorge Awaiting requested review from johnugeorge

@ChanYiLin ChanYiLin Awaiting requested review from ChanYiLin

Assignees

@terrytangyuan terrytangyuan

@ChanYiLin ChanYiLin

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip check active deadline and backoff limit if job is terminated
5 participants
@Jeffwan @kubeflow-bot @ChanYiLin @k8s-ci-robot @terrytangyuan