Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Skip check active deadline and backoff limit if job is terminated #92

Closed
Jeffwan opened this issue May 16, 2020 · 2 comments · Fixed by #93
Closed

Skip check active deadline and backoff limit if job is terminated #92

Jeffwan opened this issue May 16, 2020 · 2 comments · Fixed by #93
Assignees
@Jeffwan
Labels
area/operator kind/bug

Comments

@Jeffwan
Copy link
Member

Jeffwan commented May 16, 2020

Comes from kubeflow/training-operator#1111.

Seems kubeflow/common doesn't have this patch yet. We need to update the reconcile logic.
@Jeffwan Jeffwan self-assigned this May 16, 2020
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/operator 0.93
kind/bug 0.57

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@kf-label-bot-dev
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
bug 0.57

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@kf-label-bot-dev kf-label-bot-dev bot added the bug label May 16, 2020
@jlewi jlewi removed the bug label May 17, 2020
@Jeffwan Jeffwan mentioned this issue May 17, 2020
Merged
georgkaleido pushed a commit to georgkaleido/common that referenced this issue Jun 9, 2022
@Jerome-Kaleido
Add option for inference on CPU (kubeflow#92)
d426bc4 
* Add cuda/cpu arguments everywhere necessary

* Fix argument in RemovebgServer init function

* Rename device as compute_device

* Update Dockerfile and docker-compose.yml to handle the extra env COMPUTE_DEVICE

* Add an extra argument "compute_device" to force computation on either cuda (like before) or cpu (this is new)

* Update dependencies

* Update dependencies

* Update dependencies

* Fix im_for_trimap_tr being always copied to gpu

* Fix core tests foreground_anchors

* Update README
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Jeffwan Jeffwan

Labels
area/operator kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip some logics for terminated job and add PodGroup reconcile loop Jeffwan/common
2 participants
@jlewi @Jeffwan