This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
change type of rtype to commonv1.ReplicaType #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @terrytangyuan |
gaocegege
reviewed
May 25, 2021
|
Did you do |
Please refer to https://travis-ci.com/github/kubeflow/common/builds/226788990 |
|
common/pkg/apis/common/v1/types.go Line 151 in eb55dde Nice catch. /lgtm |
|
/approve |
Jeffwan
approved these changes
Jun 1, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jeffwan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Jeffwan
added a commit
to Jeffwan/common
that referenced
this pull request
Aug 30, 2021
kubeflow#135 This change brings some extra side effects and make training operator dependency upgrade fail. Since this change is kind of refactor, we determine to revert it at this moment.
google-oss-robot
pushed a commit
that referenced
this pull request
Aug 30, 2021
Jeffwan
added a commit
to Jeffwan/common
that referenced
this pull request
Sep 19, 2021
Since reconciler.v1 add more changes. This revert's scope is larger than original PR. Signed-off-by: Jiaxin Shan <[email protected]>
Jeffwan
added a commit
to Jeffwan/common
that referenced
this pull request
Sep 19, 2021
Since reconciler.v1 add more changes. This revert's scope is larger than original PR. Signed-off-by: Jiaxin Shan <[email protected]>
Jeffwan
added a commit
to Jeffwan/common
that referenced
this pull request
Sep 20, 2021
Since reconciler.v1 add more changes. This revert's scope is larger than original PR. Signed-off-by: Jiaxin Shan <[email protected]>
gaocegege
pushed a commit
to gaocegege/common
that referenced
this pull request
Nov 23, 2021
kubeflow#135 This change brings some extra side effects and make training operator dependency upgrade fail. Since this change is kind of refactor, we determine to revert it at this moment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #134