Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Type of replicaType is not consistent in common project #134

Closed
MartinForReal opened this issue May 25, 2021 · 1 comment · Fixed by #135
Closed

Type of replicaType is not consistent in common project #134

MartinForReal opened this issue May 25, 2021 · 1 comment · Fixed by #135
Labels
good first issue Good for newcomers

Comments

@MartinForReal
Copy link
Member

Is there any thought about why type of replicaType is not consistent across the common project?

e.g.

common/pkg/apis/common/v1/interface.go

Line 47 in eb55dde

SetClusterSpec(job interface{}, podTemplate *v1.PodTemplateSpec, rtype, index string) error

vs

common/pkg/apis/common/v1/interface.go

Line 57 in eb55dde

IsMasterRole(replicas map[ReplicaType]*ReplicaSpec, rtype ReplicaType, index int) bool

I think maybe it is a good idea to define replicaType as commonv1.ReplicaType.
@MartinForReal MartinForReal mentioned this issue May 25, 2021
Merged
@terrytangyuan terrytangyuan linked a pull request May 25, 2021 that will close this issue
change type of rtype to commonv1.ReplicaType #135
Merged
@Jeffwan
Copy link
Member

Jeffwan commented May 27, 2021

It makes no difference from usage perspective but I agree we should make it consistent.

@Jeffwan Jeffwan added the good first issue Good for newcomers label May 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change type of rtype to commonv1.ReplicaType
2 participants
@Jeffwan @MartinForReal