Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unifying logging library to klog #1019

Merged
merged 9 commits into from
Aug 17, 2019
Merged

unifying logging library to klog #1019

merged 9 commits into from
Aug 17, 2019

Conversation

kadisi
Copy link
Member

@kadisi kadisi commented Aug 13, 2019 •
edited by fisherxu
Loading

Signed-off-by: zhangjie [email protected]

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind test
/kind failing-test
/kind feature

/kind cleanup

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Unifying logging library to klog

@kubeedge-bot kubeedge-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 13, 2019
@kubeedge-bot kubeedge-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 13, 2019
@kadisi kadisi mentioned this pull request Aug 13, 2019
Closed
3 tasks
@fisherxu
Copy link
Member

Thanks for this great change! Suggest split the commit by components :) @kadisi

@kadisi kadisi changed the title unifying logging library to klog unifying cloud component logging library to klog Aug 13, 2019
@kubeedge-bot kubeedge-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 13, 2019
@kadisi kadisi changed the title unifying cloud component logging library to klog unifying logging library to klog Aug 13, 2019
@sids-b sids-b mentioned this pull request Aug 13, 2019
Closed
@subpathdev
Copy link
Member

@kadisi could you please add 'cloud' in the name of the pr?

@kubeedge-bot kubeedge-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 14, 2019
@kadisi
Copy link
Member Author

kadisi commented Aug 14, 2019

@fisherxu @rohitsardesai83 @subpathdev @sujithsimon22 PTAL

fisherxu
fisherxu reviewed Aug 15, 2019
View reviewed changes
cloud/pkg/devicecontroller/config/buffer.go Show resolved Hide resolved
cloud/pkg/devicecontroller/config/context.go Outdated Show resolved Hide resolved
cloud/pkg/devicecontroller/config/kube.go Outdated Show resolved Hide resolved
tests/stubs/example/main.go Outdated Show resolved Hide resolved
mappers/bluetooth_mapper/main.go Outdated Show resolved Hide resolved
edge/test/integration/utils/common/log.go Outdated Show resolved Hide resolved
fisherxu
fisherxu reviewed Aug 16, 2019
View reviewed changes
Copy link
Member

@fisherxu fisherxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the log change and the import format fix! Just some nits

tests/stubs/example/main.go Show resolved Hide resolved
tests/performance/nodedensity/nodedensity_suite_test.go Outdated Show resolved Hide resolved
tests/performance/loadtest/loadtest_suite_test.go Outdated Show resolved Hide resolved
tests/performance/hubtest/hubtest_suite_test.go Outdated Show resolved Hide resolved
tests/e2e/utils/status.go Outdated Show resolved Hide resolved
edge/test/integration/utils/common/status.go Outdated Show resolved Hide resolved
edge/test/integration/device/device_suite_test.go Outdated Show resolved Hide resolved
edge/test/integration/device/device_suite_test.go Outdated Show resolved Hide resolved
edge/test/integration/appdeployment/application_suite_test.go Outdated Show resolved Hide resolved
edge/pkg/common/dbm/db.go Outdated Show resolved Hide resolved
@kadisi kadisi force-pushed the klog branch 5 times, most recently from 66d5f2d to 2cc49a6 Compare August 16, 2019 11:13
@kadisi kadisi force-pushed the klog branch 2 times, most recently from 04f2cc1 to 87c6244 Compare August 16, 2019 11:49
@fisherxu
Copy link
Member

Thanks!! @kadisi
/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2019
@subpathdev
Copy link
Member

thanks @kadisi; great work

kevin-wangzefeng
kevin-wangzefeng reviewed Aug 17, 2019
View reviewed changes
Copy link
Member

@kevin-wangzefeng kevin-wangzefeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Thanks!

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevin-wangzefeng, subpathdev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2019
@kubeedge-bot kubeedge-bot merged commit 4a0526e into kubeedge:master Aug 17, 2019
@kadisi kadisi deleted the klog branch August 17, 2019 11:28
@kevin-wangzefeng kevin-wangzefeng added this to the v1.2 milestone Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sujithsimon22 sujithsimon22 sujithsimon22 left review comments

@fisherxu fisherxu fisherxu left review comments

@rohitsardesai83 rohitsardesai83 rohitsardesai83 left review comments

@kevin-wangzefeng kevin-wangzefeng kevin-wangzefeng left review comments

@subpathdev subpathdev subpathdev approved these changes

@Baoqiang-Zhang Baoqiang-Zhang Awaiting requested review from Baoqiang-Zhang

@edisonxiang edisonxiang Awaiting requested review from edisonxiang

@naveensriram naveensriram Awaiting requested review from naveensriram

@sids-b sids-b Awaiting requested review from sids-b

Assignees

@kevin-wangzefeng kevin-wangzefeng

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
7 participants
@kadisi @fisherxu @subpathdev @kubeedge-bot @kevin-wangzefeng @rohitsardesai83 @sujithsimon22