-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support to config log rotate in kubeedge #27
Conversation
Signed-off-by: clarklee <[email protected]>
Welcome @clarklee92! It looks like this is your first PR to kubeedge/beehive 🎉 |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@clarklee92 , we are changing the logging library to klog... Please take a look kubeedge/kubeedge#1019 |
Thanks for your contribution, and yes, we are now changing the logging library to klog, could please take a review :) @clarklee92 |
That's all right. |
Later today I will add an unit file to run the edgecore. |
|
/close |
@kevin-wangzefeng: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hello,
Log rotate is required by users, I try to give this PR to make rotate configurable. You may put the content in
logging.yaml
like this:Signed-off-by: clarklee [email protected]