Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to config log rotate in kubeedge #27

Closed
wants to merge 1 commit into from

Conversation

clarklee92
Copy link

Hello,
Log rotate is required by users, I try to give this PR to make rotate configurable. You may put the content in logging.yaml like this:

rollingPolicy: "daily" # size or daily
logRotateSize: 10 #M Bytes, if rolling policy is 'size'
logBackupCount: 7
logRotateDate: 1 # day step

Signed-off-by: clarklee [email protected]

@kubeedge-bot
Copy link
Collaborator

Welcome @clarklee92! It looks like this is your first PR to kubeedge/beehive 🎉

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: fisherxu

If they are not already assigned, you can assign the PR to them by writing /assign @fisherxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubeedge-bot kubeedge-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 13, 2019
@sids-b
Copy link
Member

sids-b commented Aug 13, 2019

@clarklee92 , we are changing the logging library to klog... Please take a look kubeedge/kubeedge#1019

cc @kevin-wangzefeng @fisherxu @kadisi

@fisherxu
Copy link
Member

@clarklee92 , we are changing the logging library to klog... Please take a look

Thanks for your contribution, and yes, we are now changing the logging library to klog, could please take a review :) @clarklee92

@clarklee92
Copy link
Author

@clarklee92 , we are changing the logging library to klog... Please take a look

Thanks for your contribution, and yes, we are now changing the logging library to klog, could please take a review :) @clarklee92

That's all right.

@subpathdev
Copy link
Member

Later today I will add an unit file to run the edgecore.
Would this resolve your issue @clarklee92?

@fisherxu
Copy link
Member

beehive has been moved to kubeedge/staging, we can raise PR under kubeedge/kubeedge, close this now :)
/close

@kevin-wangzefeng
Copy link
Member

/close

@kubeedge-bot
Copy link
Collaborator

@kevin-wangzefeng: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants